Issue metadata
Sign in to add a comment
|
Unnecessary separator is shown in Bluetooth device list in System tray. |
||||||||||||||||||||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (0) Make sure there is at least one Bluetooth device around Chromebook, and none of devices have been paired with the Chromebook. (1) Open system tray and open Bluetooth menu. (2) Turn on bluetooth by clicking the toggle button. What is the expected result? Unpaired devices are shown without a separator. What happens instead? A separator is seen below the progress bar. (As seen in the attached screenshot.) Marking this as regression, as the separator is not shown in the pre-MD system tray.
,
Dec 22 2016
Issue 676403 has been merged into this issue.
,
Dec 22 2016
,
Dec 22 2016
,
Dec 26 2016
A CL is under review: https://codereview.chromium.org/2582293003/ I'll request a merge once it lands on the main branch.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b613df596c63e3e69b4addaaa676e54877b8f261 commit b613df596c63e3e69b4addaaa676e54877b8f261 Author: fukino <fukino@chromium.org> Date: Tue Jan 10 04:40:59 2017 MD system tray: Avoid adding separator as the first item of Bluetooth device list. In pre-MD device list, TrayDetailsView::AddScrollSeparator() checked if the added separator was the first item or not. https://codesearch.chromium.org/chromium/src/ash/common/system/tray/tray_details_view.cc?q=TrayDetailsView::AddScrollSeparator&sq=package:chromium&l=430&dr=CSs We should do the same check in MD version of Bluetooth device list, too. BUG= 675566 Review-Url: https://codereview.chromium.org/2582293003 Cr-Commit-Position: refs/heads/master@{#442473} [modify] https://crrev.com/b613df596c63e3e69b4addaaa676e54877b8f261/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
,
Jan 10 2017
,
Jan 11 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5076457588c1ed7f300b8583f0cbfe61bb173725 commit 5076457588c1ed7f300b8583f0cbfe61bb173725 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Jan 11 05:00:35 2017 MD system tray: Avoid adding separator as the first item of Bluetooth device list. In pre-MD device list, TrayDetailsView::AddScrollSeparator() checked if the added separator was the first item or not. https://codesearch.chromium.org/chromium/src/ash/common/system/tray/tray_details_view.cc?q=TrayDetailsView::AddScrollSeparator&sq=package:chromium&l=430&dr=CSs We should do the same check in MD version of Bluetooth device list, too. BUG= 675566 TBR=jennyz@chromium.org Review-Url: https://codereview.chromium.org/2582293003 Cr-Commit-Position: refs/heads/master@{#442473} (cherry picked from commit b613df596c63e3e69b4addaaa676e54877b8f261) Review-Url: https://codereview.chromium.org/2622143002 . Cr-Commit-Position: refs/branch-heads/2924@{#727} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/5076457588c1ed7f300b8583f0cbfe61bb173725/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
,
Jan 11 2017
,
Jan 12 2017
,
May 9 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by fukino@chromium.org
, Dec 19 2016