clang-format produced code that:
- Doesn't match Chromium style
- No sane human would ever choose
Here's the code before formatting:
std::vector<content::ContentBrowserClient::ServiceManifestInfo>
ChromeContentBrowserClient::GetExtraServiceManifests() {
return std::vector<content::ContentBrowserClient::ServiceManifestInfo>({
#if !defined(DISABLE_NACL)
{nacl::kNaClLoaderServiceName, IDR_NACL_LOADER_MANIFEST},
#if defined(OS_WIN)
{nacl::kNaClBrokerServiceName, IDR_NACL_BROKER_MANIFEST},
#endif // defined(OS_WIN)
#endif // !defined(DISABLE_NACL)
});
}
Here's the code after formatting:
std::vector<content::ContentBrowserClient::ServiceManifestInfo>
ChromeContentBrowserClient::GetExtraServiceManifests() {
return std::vector<content::ContentBrowserClient::ServiceManifestInfo>({
#if !defined(DISABLE_NACL)
{nacl::kNaClLoaderServiceName, IDR_NACL_LOADER_MANIFEST},
#if defined(OS_WIN)
{nacl::kNaClBrokerServiceName, IDR_NACL_BROKER_MANIFEST},
#endif // defined(OS_WIN)
#endif // !defined(DISABLE_NACL)
});
}
Here's how it ought to look:
std::vector<content::ContentBrowserClient::ServiceManifestInfo>
ChromeContentBrowserClient::GetExtraServiceManifests() {
return std::vector<content::ContentBrowserClient::ServiceManifestInfo>({
#if !defined(DISABLE_NACL)
{nacl::kNaClLoaderServiceName, IDR_NACL_LOADER_MANIFEST},
#if defined(OS_WIN)
{nacl::kNaClBrokerServiceName, IDR_NACL_BROKER_MANIFEST},
#endif // defined(OS_WIN)
#endif // !defined(DISABLE_NACL)
});
}
Code review link for full files/context:
https://codereview.chromium.org/2501913002/diff/320001/chrome/browser/chrome_content_browser_client.cc
Comment 1 by dcheng@chromium.org
, Dec 19 2016