New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675552 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Chrome][M55] M3U file is downloaded when users try to access HLS contents

Reported by seiyon.p...@gmail.com, Dec 19 2016

Issue description

Example URL:
http://devimages.apple.com.edgekey.net/streaming/examples/bipbop_4x3/gear0/prog_index.m3u8

Steps to reproduce the problem:
1. Launch Chrome
2. Go to http://devimages.apple.com.edgekey.net/streaming/examples/bipbop_4x3/gear0/prog_index.m3u8

What is the expected behavior?
HLS content should be played.

What went wrong?
M3U file is downloaded.

Did this work before? Yes M52

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 7.0
Flash Version: Shockwave Flash 24.0 r0
 

Comment 1 by mef@chromium.org, Dec 19 2016

Components: -Internals>Network UI>Browser>Downloads
Gentle reminder

Comment 3 by dah...@chromium.org, Jan 12 2017

Components: Blink>Media>Video
Owner: dalecur...@chromium.org
Dale, this sounds like a media stack issue, not a downloads issue. Can you take a look?

Comment 4 by dah...@chromium.org, Jan 12 2017

Cc: dah...@chromium.org
Components: -UI>Browser>Downloads
Cc: ddorwin@chromium.org
Status: Assigned (was: Unconfirmed)
URLs are being served with audio/x-mpegurl which we don't recognize. Since it's apple's server and standard I guess this is a valid mime type we should check. WDYT ddorwin?
Any idea why we regressed from M52? Is Spitzer causing us to not query MediaPlayer or something?

According to Apple's documentation [1], this is not a valid MIME type. A similar conclusion was reached in [2]. Maybe we should try to get clarification on the valid types.

See also b/31899293#comment8.

[1] https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/StreamingMediaGuide/DeployingHTTPLiveStreaming/DeployingHTTPLiveStreaming.html#//apple_ref/doc/uid/TP40008332-CH2-SW5
[2] http://forums.slimdevices.com/showthread.php?103158-Announce-PlayHLS-Plugin-plugin-to-play-Apple-HLS-m3u8-stream/page58
Whoops, forgot about that bug over the holidays.

I'm not sure about why this might work in M52, I can't find any code which suggests we ever accepted audio/x-mpegurl as part of WMPA; MediaPlayer has no such query interface so we never queried it.

That said, if Apple itself is serving this, I think we should add support. The 2 out of 3 examples for HLS streaming from Apple includes this mime type:

https://developer.apple.com/streaming/examples/

The other uses application/vnd.apple.mpegurl. Since we're already supporting application/x-mpegurl for historical purposes, I don't see any reason not to include the other.
After downloading the streaming validator I can confirm it will accept the following mime-types:
application/vnd.apple.mpegurl
audio/x-mpegurl
audio/mpegurl
application/x-mpegurl

So we should probably support these as well and poke at Apple to update their documentation. I'll put out a CL for this shortly.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb0830575b5d15718194f802d48c80e6450eddde

commit fb0830575b5d15718194f802d48c80e6450eddde
Author: dalecurtis <dalecurtis@chromium.org>
Date: Fri Jan 20 01:47:21 2017

Add support for audio/{x-}mpegurl mime type for HLS.

I.e., add support for audio/mpegurl and audio/x-mpegurl.

Sadly, despite documentation indicating that audio/x-mpegurl is not a
standard mime-type, Apple's HLS validator and HLS example site itself
reports this mime type as valid for HLS serving. audio/mpegurl is
specified in the documentation, so also add support for it.

BUG= 675552 
TEST=updated unittests

Review-Url: https://codereview.chromium.org/2640373002
Cr-Commit-Position: refs/heads/master@{#444934}

[modify] https://crrev.com/fb0830575b5d15718194f802d48c80e6450eddde/content/browser/media/media_canplaytype_browsertest.cc
[modify] https://crrev.com/fb0830575b5d15718194f802d48c80e6450eddde/media/base/mime_util_internal.cc
[modify] https://crrev.com/fb0830575b5d15718194f802d48c80e6450eddde/media/base/mime_util_unittest.cc

Labels: Merge-Request-57
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-57 M-57
Status: Fixed (was: Assigned)
This was already on M57, whoops. Sorry for the noise!

Sign in to add a comment