New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675542 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 675439
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tab crash is seen on exiting full screen in Youtube

Project Member Reported by sandeepkumars@chromium.org, Dec 19 2016

Issue description

Chrome Version: Working on 57.0.2955.0/9100.0.0 dev channel Parrot, Daisy, Jerry
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to Chrome>> launch browser>> open Youtube>> double click on the video to full screen>> and again click on the video>> and observe

Expected: Tab crash should not be seen
Actual: Instead tab crash is seen 

This is a Regression issue as issue is not seen in 56.0.2924.26/9000.26.0 beta-channel Parrot

Stack Trace
=======================
Thread 0 CRASHED [SIGSEGV @ 0x000000dc ] MAGIC SIGNATURE THREAD
Stack Quality97%Show frame trust levels

0x00007fa8013b65e7	(chrome -HashTable.h:710)	blink::RuleFeatureSet::add(blink::RuleFeatureSet const&)
0x00007fa804bc8c81	(chrome -ScopedStyleResolver.cpp:120)	blink::ScopedStyleResolver::collectFeaturesTo(blink::RuleFeatureSet&, blink::HeapHashSet<blink::Member<blink::StyleSheetContents const>, WTF::MemberHash<blink::StyleSheetContents const>, WTF::HashTraits<blink::Member<blink::StyleSheetContents const> > >&) const
0x00007fa804c4cb69	(chrome -StyleEngine.cpp:570)	blink::StyleEngine::collectScopedStyleFeaturesTo(blink::RuleFeatureSet&) const
0x00007fa8013b1426	(chrome -CSSGlobalRuleSet.cpp:66)	blink::CSSGlobalRuleSet::update(blink::Document&)
0x00007fa804c0d0bd	(chrome -Element.cpp:3364)	blink::Element::setContainsFullScreenElement(bool)
0x00007fa804c0d10a	(chrome -Element.cpp:3393)	blink::Element::setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(bool)
0x00007fa804c1a02b	(chrome -Fullscreen.cpp:661)	blink::Fullscreen::didEnterFullscreen()
0x00007fa8049321a8	(chrome -FullscreenController.cpp:88)	blink::FullscreenController::didEnterFullscreen()
0x00007fa8055d7c11	(chrome -render_widget.cc:1187)	content::RenderWidget::Resize(content::ResizeParams const&)
0x00007fa8055c9c50	(chrome -render_view_impl.cc:2339)	content::RenderViewImpl::OnResize(content::ResizeParams const&)
0x00007fa8055dc0e4	(chrome -tuple.h:91)	content::RenderWidget::OnMessageReceived(IPC::Message const&)
0x00007fa8055cff69	(chrome -render_view_impl.cc:1265)	content::RenderViewImpl::OnMessageReceived(IPC::Message const&)
0x00007fa8047dc3ec	(chrome -child_thread_impl.cc:741)	content::ChildThreadImpl::OnMessageReceived(IPC::Message const&)
0x00007fa803429ea6	(chrome -ipc_channel_proxy.cc:340)	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&)
0x00007fa801170f4c	(chrome -callback.h:68)	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x00007fa801254c43	(chrome -task_queue_manager.cc:499)	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow*)
0x00007fa801256199	(chrome -task_queue_manager.cc:304)	blink::scheduler::TaskQueueManager::DoWork(bool)
0x00007fa801170f4c	(chrome -callback.h:68)	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x00007fa80115bed0	(chrome -message_loop.cc:413)	base::MessageLoop::DoWork()
0x00007fa80115c408	(chrome -message_pump_default.cc:33)	base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
0x00007fa802aaa997	(chrome -run_loop.cc:37)	base::RunLoop::Run()
0x00007fa8055e2f18	(chrome -renderer_main.cc:200)	content::RendererMain(content::MainFunctionParams const&)
0x00007fa802732f27	(chrome -content_main_runner.cc:344)	content::RunZygote(content::MainFunctionParams const&, content::ContentMainDelegate*)
0x00007fa802733199	(chrome -content_main_runner.cc:793)	content::ContentMainRunnerImpl::Run()
0x00007fa802731e3a	(chrome -content_main.cc:20)	content::ContentMain(content::ContentMainParams const&)
0x00007fa8013cd65a	(chrome -chrome_main.cc:112)	ChromeMain
0x00007fa7fe9e6fb5	(libc-2.19.so -libc-start.c:292)	__libc_start_main
0x00007fa8013cd479	(chrome+ 0x01226479)	_start
0x00007ffeb3260517	

 
Components: -Blink>Media>Video
Owner: foolip@chromium.org
Assigning to foolip@ for triage given FullscreenController in the stack and his recent changes.

Comment 2 by foolip@chromium.org, Dec 19 2016

Has this crash been seen only on ChromeOS? I can't reproduce on a Linux debug build. This was most likely caused by https://codereview.chromium.org/2550703002 but could also have been https://codereview.chromium.org/2530883002 or a number of other minor changes.

Comment 3 by willg...@gmail.com, Dec 19 2016

I'm was seeing the crash immediately when opening full screen on any video.

Was running 57.0.2955.0 on Edgar.

Comment 4 by foolip@chromium.org, Dec 20 2016

What is Edgar? Are there some instructions building for and testing on ChromeOS, I guess that's what I have to do to get try to reproduce this?

https://codereview.chromium.org/2573773002/ just landed and may have fixed this, it added a null check in blink::Fullscreen::didEnterFullscreen() and changed the timing of entering and exiting fullscreen.
Mergedinto: 675439
Status: Duplicate (was: Untriaged)

Sign in to add a comment