"Request desktop site" does not confirm reposting forms |
|||
Issue descriptionChrome Version: trunk OS: Android What steps will reproduce the problem? (1) Go to a site that has a form with POST method (i.e. http://yuri.twintail.org/chrome/post/simple_form.html) (2) Submit a form (3) Use "Request desktop site" from the burger menu What is the expected result? prompting to ask it's ok to repost the form content What happens instead? repost the form without asking
,
Dec 20 2016
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d commit 28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d Author: yoichio <yoichio@chromium.org> Date: Tue Dec 20 08:21:36 2016 Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ ) Reason for revert: Caused browser_test failure: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740 https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090 Original issue's description: > Reload: "Request desktop site" feature should ask reposting > > Now Android Chrome does not confirm if it is expected to repost a form > on selecting "Request desktop site". > > This change modifies to ask it as we do in other cases. > > If a user reject reposting, the navigation switches to use desktop user > agent strings as usuals, but only for the next navigation and > following ones. > > BUG= 675522 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 > Cr-Commit-Position: refs/heads/master@{#439727} TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 675522 Review-Url: https://codereview.chromium.org/2593533002 Cr-Commit-Position: refs/heads/master@{#439749} [modify] https://crrev.com/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d/content/browser/frame_host/navigation_controller_android.cc
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f7be0c112fbe3bb4c68436eaafe7ba0ff48a5e0 commit 4f7be0c112fbe3bb4c68436eaafe7ba0ff48a5e0 Author: yoichio <yoichio@chromium.org> Date: Tue Dec 20 08:27:10 2016 Reland of load: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2593533002/ ) Reason for revert: This is not culprit Original issue's description: > Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ ) > > Reason for revert: > Caused browser_test failure: > https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770 > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179 > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740 > https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090 > > Original issue's description: > > Reload: "Request desktop site" feature should ask reposting > > > > Now Android Chrome does not confirm if it is expected to repost a form > > on selecting "Request desktop site". > > > > This change modifies to ask it as we do in other cases. > > > > If a user reject reposting, the navigation switches to use desktop user > > agent strings as usuals, but only for the next navigation and > > following ones. > > > > BUG= 675522 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > > > Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 > > Cr-Commit-Position: refs/heads/master@{#439727} > > TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 675522 > > Committed: https://crrev.com/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d > Cr-Commit-Position: refs/heads/master@{#439749} TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 675522 Review-Url: https://codereview.chromium.org/2587343002 Cr-Commit-Position: refs/heads/master@{#439751} [modify] https://crrev.com/4f7be0c112fbe3bb4c68436eaafe7ba0ff48a5e0/content/browser/frame_host/navigation_controller_android.cc
,
Jan 3 2017
verified with last chrome version. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 20 2016