Search geolocation pre disclosure metrics are being recorded too early |
|||||
Issue descriptionThe metrics are meant to log the state of the geolocation permission of the DSE CCTLD origin immediately before the disclosure could be shown for the first time. The metric is logged slightly too late after the permission is checked, meaning all the values logged are ASK.
,
Dec 28 2016
This has been on stable for some time now and there have been no problems.
,
Dec 28 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48b4ef3b15e8431ff93954be5bc72af1d1a69429 commit 48b4ef3b15e8431ff93954be5bc72af1d1a69429 Author: Ben Wells <benwells@chromium.org> Date: Wed Dec 28 03:43:03 2016 Record search geolocation pre-disclosure metrics earlier The metrics are meant to record the distribution of geolocation permissions for the DSE CCTLD origin, but are recorded after the permissions are checked. This means all metrics recorded are ASK. BUG= 675503 Review-Url: https://codereview.chromium.org/2585153002 Cr-Commit-Position: refs/heads/master@{#439639} (cherry picked from commit 51cb46ec4e347179835637fe59ace00c707ba074) Review-Url: https://codereview.chromium.org/2604993002 . Cr-Commit-Position: refs/branch-heads/2924@{#628} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/48b4ef3b15e8431ff93954be5bc72af1d1a69429/chrome/browser/android/search_geolocation_disclosure_tab_helper.cc
,
Dec 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Dec 20 2016