Screenshot for https://codereview.chromium.org/2586373003/

Deleted: Screen Shot 2017-01-05 at 4.21.23 pm.png 59.6 KB

	Screen Shot 2017-01-05 at 4.21.23 pm.png 59.6 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84ce68dbf0aee72a6cfc16b3d50124078836d83c

commit 84ce68dbf0aee72a6cfc16b3d50124078836d83c
Author: tapted <tapted@chromium.org>
Date: Tue Jan 10 05:53:46 2017

MacViews: Allow toolkit-views for "Global Error" bubbles.

The views dialogs will be chosen when run with the --secondary-ui-md
flag.

When the parent is a Cocoa browser window, an anchor point is chosen
rather than an anchor view, and the GlobalErrorBubbleView constructor is
updated to use this point when the anchor view is null.

The tricker part is that:
a) These dialogs are persistent (they do not dismiss when they lose
focus), and
b) The dialogs appear on the right side of the window,

This means they're more prone to "falling off" their anchor point when
resizing the browser window. For this, add a "BubbleAnchorHelper"
framework which is enabled by passing a visible toolkit-views bubble to
a KeepBubbleAnchored() function. The framework captures the anchor
position and ensures it is maintained when changes to the parent
NSWindow are observed.

Screenshot at http://crbug.com/675496#c1

BUG=675496

Review-Url: https://codereview.chromium.org/2586373003
Cr-Commit-Position: refs/heads/master@{#442503}

[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/bubble_anchor_helper_views.h
[add] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[add] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/bubble_anchor_helper_views_unittest.mm
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/global_error_bubble_controller.h
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/global_error_bubble_controller.mm
[add] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/global_error_bubble_controller_views.mm
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/browser/ui/views/global_error_bubble_view.h
[modify] https://crrev.com/84ce68dbf0aee72a6cfc16b3d50124078836d83c/chrome/test/BUILD.gn

Converting this into a Harmony bug.

some "initial state" screenshots

 - ExtensionGlobalError (blacklisted extension) https://bugs.chromium.org/p/chromium/issues/attachment?aid=302155&inline=1
 - ExtensionDisabledGlobalError https://bugs.chromium.org/p/chromium/issues/attachment?aid=302155&inline=1 (also above)
 - ExternalInstallBubbleAlert https://bugs.chromium.org/p/chromium/issues/attachment?aid=302157&inline=1
 - RecoveryInstallGlobalError (Windows and Mac) https://bugs.chromium.org/p/chromium/issues/attachment?aid=302158&inline=1 
 - SigninGlobalError (non-ChromeOS) https://bugs.chromium.org/p/chromium/issues/attachment?aid=302159&inline=1
 - Software Removal Tool's SRTGlobalError (Windows) https://bugs.chromium.org/p/chromium/issues/attachment?aid=303110&inline=1

(from  http://crbug.com/763233#c6 )

UX team feedback in the meeting was:
 - "Details" button should be left aligned in the extra view slot
 - Body text should align under the title text, not under the icon

For the icon, Harmony doesn't _repeat_ icons in the bubble title area when it matches the anchor.
Most cases when these are shown "For Real", the bubble should be anchored to the extension icon, or to the app menu showing the orange [!]. But for "extension is disabled" case, the app menu shows "[!]" but the bubble shows the extension icon, so we may want to show the icon for that specific case.

 Issue 766288  has been merged into this issue.

Load balancing

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da7d328849c5fb0967214dde5ef1d3710ee9034f

commit da7d328849c5fb0967214dde5ef1d3710ee9034f
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Jan 09 16:08:09 2018

For Extension Global error bubbles, added ability to place 'Details' button on the left across from the 'ok' button.

Bug: 675496
Change-Id: I9a1376a9bc30c0dd9d88c76fe54629c62bcd92f8
Reviewed-on: https://chromium-review.googlesource.com/854771
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528008}
[modify] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/extensions/extension_error_ui_default.cc
[modify] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/extensions/extension_error_ui_default.h
[modify] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/global_error/global_error.cc
[modify] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/global_error/global_error.h
[modify] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/views/global_error_bubble_view.h

MacViews triage: untagging Proj-MacViews here.