New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675480 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in SkBitmapProcState::chooseProcs

Project Member Reported by ClusterFuzz, Dec 18 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6313061054152704

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  SkBitmapProcState::chooseProcs
  SkBitmapProcLegacyShader::MakeContext
  SkImageShader::onCreateContext
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=435261:438085

Minimized Testcase (12.87 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96s-gFbz0d3OVEnY728QTeZ1ApMZxn01mzCY-qExTHO4hgjwOmhi8rulCmEKdTDWhiOXzTNGI3irzphJBQw5wkVXCuUh4AosMqB1H59_mAPkf50nAgi23Ok-LIdCQUyMBIdqPsWauSFecooMRMGT56_sc5Dew?testcase_id=6313061054152704

Additional requirements: Requires HTTP

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>Skia
Labels: Test-Predator-Correct-CLs
Owner: brianosman@chromium.org
Status: Assigned (was: Untriaged)
Using Find it, assigning to the concern owner. Below are the find it results --
The result is a list of CLs that change the crashed files. 

Author: Brian Osman
Project: chromium-skia
Changelist: https://skia.googlesource.com/skia.git/+/13bf6227c5701903b38b5c21a15c8323dec7734a
Time: Tue Dec 06 10:34:51 2016 -0500
Lines 229 of file SkBitmapProcShader.cpp which potentially caused crash are changed in this cl (frame #1, "SkBitmapProcLegacyShader::MakeContext"). 

Files SkBitmapProcState.cpp, SkImageShader.cpp are changed in this cl (and is part of stack frame #0, "SkBitmapProcState::chooseProcs")
Minimum distance from crash line to modified line: 0. (file: SkBitmapProcShader.cpp, crashed on: 229, modified: 229). 

Author: Brian Osman
Project: chromium-skia
Changelist: https://skia.googlesource.com/skia.git/+/61624f0c716b576706659750d87b6956f4c15722
Time: Fri Dec 09 14:51:59 2016 -0500
Lines 58 of file SkImageShader.cpp which potentially caused crash are changed in this cl (frame #2, "SkImageShader::onCreateContext").
Minimum distance from crash line to modified line: 0. (file: SkImageShader.cpp, crashed on: 58, modified: 58).

@Brian Osman -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: fmalita@chromium.org reed@google.com
Owner: herb@chromium.org
Re-assigning to Herb, per reed@.
Project Member

Comment 3 by ClusterFuzz, Dec 22 2016

ClusterFuzz has detected this issue as fixed in range 440242:440280.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6313061054152704

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  SkBitmapProcState::chooseProcs
  SkBitmapProcLegacyShader::MakeContext
  SkImageShader::onCreateContext
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=435261:438085
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=440242:440280

Minimized Testcase (12.87 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96s-gFbz0d3OVEnY728QTeZ1ApMZxn01mzCY-qExTHO4hgjwOmhi8rulCmEKdTDWhiOXzTNGI3irzphJBQw5wkVXCuUh4AosMqB1H59_mAPkf50nAgi23Ok-LIdCQUyMBIdqPsWauSFecooMRMGT56_sc5Dew?testcase_id=6313061054152704

Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Dec 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6313061054152704 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment