New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675437 link

Starred by 6 users
Status: Fixed
Owner:
haraken@chromium.org
Closed: Jan 2017
Cc:
█ zino@chromium.org
█ gog...@gmail.com
█ meade@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 388780



Sign in to add a comment

The DOMPoint/DOMPointReadOnly implementation are different with spec.

Reported by gog...@gmail.com, Dec 18 2016 
The DOMPoint/DOMPointReadOnly implementation are different with spec. 
They should match up with the spec.
- The two interfaces require fromPoint function.
- The DOMPoint interface no longer requires constructor using DOMPointInit object.
- The DOMPointReadOnly interface requires serializer.
- The DOMPointReadOnly interface requires implementation of matrixTransform function.

Related spec links:
  - https://drafts.fxtf.org/geometry/#dompointreadonly
  - https://drafts.fxtf.org/geometry/#dompoint

Comment 1 by gog...@gmail.com, Dec 18 2016 

I'll start to work on this issue.

Comment 3 by tkent@chromium.org, Dec 18 2016

Components: Blink>CSS

Comment 4 by alancutter@chromium.org, Dec 19 2016

Labels: Hotlist-Interop
Owner: meade@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to style TL to find a Chromium buddy for gog....
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f450a4b3e7db1497563deb7ad4e6bf25e228570

commit 1f450a4b3e7db1497563deb7ad4e6bf25e228570
Author: gogag2 <gogag2@gmail.com>
Date: Fri Dec 23 19:22:17 2016

Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG= 675437 

Review-Url: https://codereview.chromium.org/2586083002
Cr-Commit-Position: refs/heads/master@{#440651}

[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/Source/core/dom/DOMPoint.cpp
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/Source/core/dom/DOMPoint.h
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/Source/core/dom/DOMPoint.idl
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/Source/core/dom/DOMPointReadOnly.cpp
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/Source/core/dom/DOMPointReadOnly.h
[modify] https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570/third_party/WebKit/Source/core/dom/DOMPointReadOnly.idl
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e14a6ca3bed003384db8a69064fbbb9cd2a533d6

commit e14a6ca3bed003384db8a69064fbbb9cd2a533d6
Author: gogag2 <gogag2@gmail.com>
Date: Tue Jan 03 08:39:51 2017

Delete DOMPoint constructor using DOMPointInit as parameter.

Delete DOMPoint constructor using DOMPointInit as parameter.
DOMPoint interfaces do not need the constructor anymore as following spec[1].
This patch doesn't break the existing web because DOMPoint is still behind the
runtime flag.

[1] https://drafts.fxtf.org/geometry/#dom-dompoint-dompoint

BUG= 675437 

Review-Url: https://codereview.chromium.org/2606763002
Cr-Commit-Position: refs/heads/master@{#441099}

[modify] https://crrev.com/e14a6ca3bed003384db8a69064fbbb9cd2a533d6/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html
[modify] https://crrev.com/e14a6ca3bed003384db8a69064fbbb9cd2a533d6/third_party/WebKit/Source/core/dom/DOMPoint.cpp
[modify] https://crrev.com/e14a6ca3bed003384db8a69064fbbb9cd2a533d6/third_party/WebKit/Source/core/dom/DOMPoint.h
[modify] https://crrev.com/e14a6ca3bed003384db8a69064fbbb9cd2a533d6/third_party/WebKit/Source/core/dom/DOMPoint.idl

Comment 9 by meade@chromium.org, Jan 4 2017

Cc: meade@chromium.org
Owner: haraken@chromium.org
Hey haraken! Can you please own this on behalf of gog, since you've been doing reviews? Thanks!

Comment 10 by haraken@chromium.org, Jan 4 2017 

I'm happy to review but won't have to work on it myself though :)

Comment 11 by meade@chromium.org, Jan 4 2017 

For sure! The bug just needs an owner :)

Comment 12 by jinho.b...@samsung.com, Jan 13 2017

Blocking: 388780
Cc: gog...@gmail.com
Labels: -Pri-3 Pri-2
Status: Fixed (was: Assigned)
I think this work was already done.

Comment 13 by meade@chromium.org, Jan 16 2017

Cc: zino@chromium.org
haraken/zino/gogag2, could you please confirm that this was completed?
►

Sign in to add a comment