New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675412 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Crash in [ShareExtensionItemReceiver applicationDidBecomeActive]

Project Member Reported by rohitrao@chromium.org, Dec 18 2016

Issue description

This pops up pretty often on the device bots.  I don't know how to symbolize the "first throw call stack", but it seems as though we're calling an NSFileManager method with a nil URL.  This maps to [self presentedItemURL], but I don't know why that is returning nil.

A simple workaround is to check for nil and return early, but that might be wallpapering over the issue if we don't understand why the URL is nil in the first place.


2016-12-17 16:43:40.610 ios_internal_chrome_reading_list_egtests[3539:872018] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[NSFileManager contentsOfDirectoryAtURL:includingPropertiesForKeys:options:error:]: URL is nil'
*** First throw call stack:
(0x18291adb0 0x181f7ff80 0x18291acf8 0x1832a4d98 0x10033c424 0x10011c1cc 0x10011c220 0x1006bcf50 0x1006d436c 0x1006d462c 0x1006d4984 0x1007270d8 0x100726b30 0x1828d109c 0x1828d0b30 0x1828ce830 0x1827f8c50 0x183208cfc 0x100727888 0x100726f88 0x1006d4090 0x1006e8cf8 0x10012fbe8 0x10012fecc 0x10070ab54 0x100706a3c 0x18257fb28 0x18257fa8c 0x18257d028)
libc++abi.dylib: terminating with uncaught exception of type NSException
Abort trap: 6
0   EarlGrey                            0x00000001039cae3c grey_signalHandler + 92
1   libsystem_platform.dylib            0x000000018257993c _sigtramp + 52
2   libsystem_pthread.dylib             0x0000000182580ef8 pthread_kill + 112
3   libsystem_c.dylib                   0x0000000182425dac abort + 140
4   libc++abi.dylib                     0x0000000181f593f4 __cxa_bad_cast + 0
5   libc++abi.dylib                     0x0000000181f75e98 <redacted> + 0
6   libobjc.A.dylib                     0x0000000181f80248 <redacted> + 124
7   libc++abi.dylib                     0x0000000181f72f44 <redacted> + 16
8   libc++abi.dylib                     0x0000000181f7285c <redacted> + 0
9   libobjc.A.dylib                     0x0000000181f80094 <redacted> + 0
10  CoreFoundation                      0x000000018291acf8 <redacted> + 0
11  Foundation                          0x00000001832a4d98 <redacted> + 132
12  ios_internal_chrome_reading_list_egtests 0x000000010033c424 __56-[ShareExtensionItemReceiver applicationDidBecomeActive]_block_invoke + 116
13  ios_internal_chrome_reading_list_egtests 0x000000010011c1cc _ZN4base8internal8RunBlockIvJEEET_NS_3mac11ScopedBlockIU8__strongU13block_pointerFS2_DpT0_EEES6_ + 32
14  ios_internal_chrome_reading_list_egtests 0x000000010011c220 _ZN4base8internal13FunctorTraitsIPFvNS_3mac11ScopedBlockIU8__strongU13block_pointerFvvEEEEvE6InvokeIJRKS7_EEEvS9_DpOT_ + 36
15  ios_internal_chrome_reading_list_egtests 0x00000001006bcf50 _ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE + 232
16  ios_internal_chrome_reading_list_egtests 0x00000001006d436c _ZN4base11MessageLoop7RunTaskEPNS_11PendingTaskE + 436
17  ios_internal_chrome_reading_list_egtests 0x00000001006d462c _ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 56
18  ios_internal_chrome_reading_list_egtests 0x00000001006d4984 _ZN4base11MessageLoop6DoWorkEv + 340
19  ios_internal_chrome_reading_list_egtests 0x00000001007270d8 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 68
20  ios_internal_chrome_reading_list_egtests 0x0000000100726b30 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 64
21  CoreFoundation                      0x00000001828d109c <redacted> + 24
22  CoreFoundation                      0x00000001828d0b30 <redacted> + 540
23  CoreFoundation                      0x00000001828ce830 <redacted> + 724
24  CoreFoundation                      0x00000001827f8c50 CFRunLoopRunSpecific + 384
25  Foundation                          0x0000000183208cfc <redacted> + 308
26  ios_internal_chrome_reading_list_egtests 0x0000000100727888 _ZN4base20MessagePumpNSRunLoop5DoRunEPNS_11MessagePump8DelegateE + 128
27  ios_internal_chrome_reading_list_egtests 0x0000000100726f88 _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 108
28  ios_internal_chrome_reading_list_egtests 0x00000001006d4090 _ZN4base11MessageLoop10RunHandlerEv + 116
29  ios_internal_chrome_reading_list_egtests 0x00000001006e8cf8 _ZN4base7RunLoop3RunEv + 128
30  ios_internal_chrome_reading_list_egtests 0x000000010012fbe8 _ZN3web13WebThreadImpl13FileThreadRunEPN4base7RunLoopE + 44
31  ios_internal_chrome_reading_list_egtests 0x000000010012fecc _ZN3web13WebThreadImpl3RunEPN4base7RunLoopE + 128
32  ios_internal_chrome_reading_list_egtests 0x000000010070ab54 _ZN4base6Thread10ThreadMainEv + 384
33  ios_internal_chrome_reading_list_egtests 0x0000000100706a3c _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 100
34  libsystem_pthread.dylib             0x000000018257fb28 <redacted> + 156
35  libsystem_pthread.dylib             0x000000018257fa8c <redacted> + 0
36  libsystem_pthread.dylib             0x000000018257d028 thread_start + 4
 
presentedItemURL returns nil if the group floder is not accessible.
Do egtest have app-group entitlement?

There is a DCHECK to prevent this, but I think the egtests run in Release on devices.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d46b12dc7095b8aed4bc2c496b8dd9be3e78e0f

commit 2d46b12dc7095b8aed4bc2c496b8dd9be3e78e0f
Author: olivierrobin <olivierrobin@chromium.org>
Date: Tue Dec 20 08:49:06 2016

Disable Share extension item receiver if there is no app group.

EGTests don't have the application group entitlement.
Disable the Receiver in that case.

BUG= 675412 

Review-Url: https://codereview.chromium.org/2588683002
Cr-Commit-Position: refs/heads/master@{#439754}

[modify] https://crrev.com/2d46b12dc7095b8aed4bc2c496b8dd9be3e78e0f/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

Status: Fixed (was: Started)

Sign in to add a comment