Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 6754 Need performance tests/measurements for newHTTP
Starred by 5 users Reported by mal.chro...@gmail.com, Jan 22 2009 Back to list
Status: WontFix
Owner:
User never visited
Closed: Jun 20
Cc:
Components:
NextAction: ----
OS: All
Pri: 3
Type: Feature


Sign in to add a comment
We need to measure the performance of our network stack and track it over 
time to make sure it doesn't regress.


We should also be able to benchmark against other browsers.
 
Issue 799 has been merged into this issue.
Comment 2 by wtc@chromium.org, May 4 2009
Status: Assigned
mbelshe has started to work on this:
http://codereview.chromium.org/99333
Comment 3 Deleted
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15360 

------------------------------------------------------------------------
r15360 | mbelshe@google.com | 2009-05-05 17:17:50 -0700 (Tue, 05 May 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=15360&r2=15359
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/fetch_client.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/fetch_server.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_listen_socket.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_listen_socket.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_server.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_server.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_server_request_info.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_server_response_info.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_session.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_session.h

A utility driver for doing client/server HTTP transaction
tests.

This is an initial codebase - there is a lot of work to do.
But I wanted to get an initial version checked in.

http://crbug.com/6754
Review URL: http://codereview.chromium.org/99333
------------------------------------------------------------------------

Comment 5 by jon@chromium.org, May 20 2009
Labels: -Mstone-2.1 Mstone-3.0
Add label: Started.
Labels: mstone4
Labels: mstone-4
Labels: -mstone4
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17720 

------------------------------------------------------------------------
r17720 | mbelshe@google.com | 2009-06-05 00:14:15 -0700 (Fri, 05 Jun 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.cc?r1=17720&r2=17719
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.h?r1=17720&r2=17719
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache_unittest.cc?r1=17720&r2=17719

Add two small features to the HttpCache for benchmarking/debugging.

The first exposes a method to close all idle sockets.  This allows
me to create benchmark tests in the app which can close
connections before starting the test for better simulations.

The second change is to expose cache modes for cache
disabled and cache bypassed.  DISABLE sets the LOAD_DISABLE_CACHE
on every request; BYPASS sets the LOAD_BYPASS_CACHE on 
every request.

TEST=http_cache_unittest.cc
BUG= 6754 

Review URL: http://codereview.chromium.org/119189
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17722 

------------------------------------------------------------------------
r17722 | mbelshe@google.com | 2009-06-05 00:33:21 -0700 (Fri, 05 Jun 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.h?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.h?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_glue.cc?r1=17722&r2=17721
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/extensions/v8/benchmarking_extension.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/extensions/v8/benchmarking_extension.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkit_glue.h?r1=17722&r2=17721
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=17722&r2=17721

Add an extension to expose some primitives to JS for doing 
benchmarking from within Chrome.  Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.

These are controlled under a new commandline option
"--enable-benchmarking"

BUG= 6754 
TEST=none

Review URL: http://codereview.chromium.org/119191
------------------------------------------------------------------------

Status: Available
Comment 13 by jon@chromium.org, Sep 1 2009
Labels: -Pri-2 Pri-3
Labels: -mstone-4 Mstone-X
Comment 15 by oritm@chromium.org, Dec 17 2009
Labels: -Area-BrowserBackend Area-Internals
Labels Update:

Replace Area-BrowserBackend by Area-Internals
Comment 16 by wtc@chromium.org, Mar 30 2010
Labels: Internals-Network
Status: Assigned
Available + Owner == Default to Assigned
Project Member Comment 18 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Internals-Network Cr-Internals Cr-Internals-Network
Comment 19 by laforge@google.com, Apr 28 2015
Cc: -wtc@chromium.org
Comment 20 by b...@chromium.org, May 6 2015
Labels: -Cr-Internals
Labels: Hotlist-Recharge
This issue likely requires triage.  The current issue owner maybe inactive (i.e. hasn't fixed an issue in the last 30 days).  Thanks for helping out!

-Anthony
Project Member Comment 22 by sheriffbot@chromium.org, Jun 18
Labels: Hotlist-OpenBugWithCL
A change has landed for this issue, but it's been open for over 6 months. Please review and close it if applicable. If this issue should remain open, remove the "Hotlist-OpenBugWithCL" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix
This is largely covered today by uma histograms + chirp alerts.
Sign in to add a comment