New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675397 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Exclude lighthouse-background.js from codesearch

Project Member Reported by paulir...@chromium.org, Dec 17 2016

Issue description

lighthouse-background.js is a compiled JS file which I maintain, and is located here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/?q=f:lighthouse&sq=package:chromium&dr

It would be better to exclude entirely from codesearch, as the matches within it are not useful.
However if that's a problem, a next best solution would to get the ~~TOO LARGE~~ message that we see on chromium's histograms.xml

Would that work?

Thanks!
 
Components: Platform>DevTools

Comment 2 by emso@chromium.org, Dec 19 2016

Status: Available (was: Untriaged)
We could potentially filter out the file, but before we dive into what that would look like, I'd like to understand the problem a little bit more. Could you expand on why the matches aren't useful? 
lighthouse-background is a compiled javascript file;built in a separate projected and rolled into Blink regularly.
What makes it particularly annoying is that within it is a slightly older version of some files from third_party/WebKit/Source/devtools/front_end/. 

Since it shows up in search, the team working on devtools finds lighthouse-background in the search results, when it is definitely never the intended result. As an example, look at this search: https://cs.chromium.org/search/?q=NetworkManager%5C.fromTarget&sq=package:chromium&type=cs

The top result looks about right, but if you click on it, you'll not only be waiting for ~30 seconds for the page to render, but it's old code.


Comment 4 by allada@chromium.org, Jan 10 2017

I will +1 this.

Since Javascript currently does not support ability to click into code to navigate much of our team has developed some muscle memory to filter out different code from different areas to find what we need.

My muscle memory is something like:

"f:devtools -f:out"

Otherwise we get results form all kinds of places that are not at all relevant. Lighthouse recently caused us to now also get results from it, which means we now need:

"f:devtools -f:out -f:lighthouse"

A good example of this is if I was looking for all calls of:
"requestHeadersText"

See what happens if you search with:
"-f:out f:devtools requestHeadersText"

Comment 5 by emso@chromium.org, May 17 2017

Labels: Stability Search
Owner: ddoman@chromium.org
Status: Assigned (was: Available)

Comment 6 by ddoman@chromium.org, Jul 28 2017

Owner: emso@chromium.org

Comment 7 by emso@chromium.org, Nov 2 2017

Owner: ----
Status: Available (was: Assigned)
Status: WontFix (was: Available)

Sign in to add a comment