MD Settings: arrow keys on sliders scroll the page |
||||||
Issue descriptionArrow keys on sliders at chrome://md-settings/fonts scroll the page (up/down => vertically, left/right => horizontally) -- even when there's no horizontal scrollbar thanks to issue 657718 . Might also reproduce at chrome://md-settings/pointer-overlay and chrome://md-settings/keyboard-overlay -- will test when I can.
,
Jan 9 2017
This seems to be a problem with paper-slider not stopping arrow key propagation, see the demo: https://elements.polymer-project.org/elements/paper-slider?view=demo:demo/index.html&active=paper-slider It should be simple to fix for cr_slider though. I'll take a look since I was just in there.
,
Jan 9 2017
Created an issue in github since the paper-slider behavior is unexpected: https://github.com/PolymerElements/paper-slider/issues/161
,
Jan 10 2017
Hm. calling event.stopPropagation in a keyBindings behavior in cr_slider.js does not work. It seems like we will need to fix this in paper-slider itself. I'll need to ask someone about how to go about that.
,
Jan 10 2017
,
Jan 17 2017
github pull request: https://github.com/stevenjb/paper-slider/pull/1 I will ask about local paper element modifications at Wednesday's standup.
,
Jan 18 2017
stevenjb@: you're attempting to change your own repo, you need to send a pull request against https://github.com/PolymerElements/paper-slider
,
Jan 18 2017
Oops, thanks. Correct pull request is here: https://github.com/PolymerElements/paper-slider/pull/165
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2bec78f3efa4fe7e9766938c606367df553070f commit a2bec78f3efa4fe7e9766938c606367df553070f Author: stevenjb <stevenjb@chromium.org> Date: Sat Jan 21 02:25:49 2017 Polymer: roll paper-slider, 1.0.11 -> 1.0.13 Primarily this picks up a fix to preven arrow keys from scrolling the page when used with a paper slider focused. BUG= 675393 Review-Url: https://codereview.chromium.org/2646943003 Cr-Commit-Position: refs/heads/master@{#445254} [modify] https://crrev.com/a2bec78f3efa4fe7e9766938c606367df553070f/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/a2bec78f3efa4fe7e9766938c606367df553070f/third_party/polymer/v1_0/components-chromium/paper-slider/bower.json [modify] https://crrev.com/a2bec78f3efa4fe7e9766938c606367df553070f/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js [modify] https://crrev.com/a2bec78f3efa4fe7e9766938c606367df553070f/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html [modify] https://crrev.com/a2bec78f3efa4fe7e9766938c606367df553070f/third_party/polymer/v1_0/components_summary.txt
,
Jan 23 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbuck...@chromium.org
, Jan 6 2017Cc: steve...@chromium.org
Labels: Hotlist-MD-Settings-PageA11y
Status: Assigned (was: Available)