1. chrome://md-settings 2. tap the avatar in People (goes to chrome://md-settings/manageProfile) 3. tap one of the avatar choices 4. Alt-Left Expected: Page navigates back Actual: Icon selection moves left Alt-Right has the same problem.
in the context of the user manager, I think this grid should probably ignore modifiers. but open to discussion on this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6daa9df237e81ebc10a0f176685582f3924cd9c commit b6daa9df237e81ebc10a0f176685582f3924cd9c Author: dbeam <dbeam@chromium.org> Date: Tue Dec 20 23:48:53 2016 MD Settings: ignore modified key events in the profile avatar grid It responds to left and right arrow, which can sometimes prevent browser shortcuts like Back and Forward if not done correctly. R=mahmadi@chromium.org BUG= 675383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2586113002 Cr-Commit-Position: refs/heads/master@{#439932} [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/inspect/inspect.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/ntp4/dot_list.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/options/cookies_list.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/pdf/pdf.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/print_preview/common/overlay.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/print_preview/previewarea/preview_area.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/print_preview/print_preview.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/print_preview/search/destination_list_item.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/browser/resources/settings/people_page/manage_profile.html [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/cr_elements/cr_profile_avatar_selector/compiled_resources2.gyp [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.html [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/js/cr/ui/focus_row.js [modify] https://crrev.com/b6daa9df237e81ebc10a0f176685582f3924cd9c/ui/webui/resources/js/util.js
Comment 1 by dbeam@chromium.org
, Dec 18 2016