New issue
Advanced search Search tips

Issue 675381 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

MD Settings: Import dialog opens too large, then resizes

Project Member Reported by michae...@chromium.org, Dec 17 2016

Issue description

OS: Windows 10.1 Anniversary

The "Import bookmarks and settings" dialog opens at a larger height than it should be, then shrinks quite a bit. This seems to be because Edge only one item can be imported from Edge so a lot of checkboxes get hidden. Would be better if the form would be populated before being displayed.

See video and stills attached.
 
frame1.png
198 KB View Download
frame2.png
198 KB View Download
frame14.png
197 KB View Download
Dialog.mp4
404 KB View Download
Cc: dbeam@chromium.org dpa...@chromium.org
Status: Started (was: Assigned)
Great I'll take this on. I have a Windows box.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dd55db3211dcdd9fd6d8e77a3c12ee8cf041938

commit 9dd55db3211dcdd9fd6d8e77a3c12ee8cf041938
Author: tommycli <tommycli@chromium.org>
Date: Thu Dec 22 15:54:18 2016

MD Settings: Defer opening Import Dialog dialog to prevent UI flicker

This defers opening the dialog until the browser profiles data is
populated to avoid UI flicker.

BUG= 675381 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2596083002
Cr-Commit-Position: refs/heads/master@{#440430}

[modify] https://crrev.com/9dd55db3211dcdd9fd6d8e77a3c12ee8cf041938/chrome/browser/resources/settings/people_page/import_data_dialog.js
[modify] https://crrev.com/9dd55db3211dcdd9fd6d8e77a3c12ee8cf041938/chrome/test/data/webui/settings/import_data_dialog_test.js

Status: Fixed (was: Started)

Sign in to add a comment