New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675374 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Upstreaming followup: add TodayExtension.ExtensionInitialized to tools/metrics/actions/actions.xml

Project Member Reported by sdefresne@chromium.org, Dec 17 2016

Issue description

Presubmit warning when upstreaming ios/chrome/today_extension code:

File ios/chrome/today_extension/today_view_controller.mm line 295: TodayExtension.ExtensionInitialized is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.

 
Status: Started (was: Assigned)
Cc: noyau@chromium.org
noyau: those are followup to upstreaming work.

Some of them can already be addressed now (UMA histograms and actions.xml). If you want, please feel free to split in smaller issues and assign them to owners.
Components: Internals>Metrics
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33387355ea2adb63f7be7bd58f819123f894e6c

commit f33387355ea2adb63f7be7bd58f819123f894e6c
Author: olivierrobin <olivierrobin@chromium.org>
Date: Tue Apr 11 22:30:07 2017

Add UserActions for Today extension.

BUG=675374

Review-Url: https://codereview.chromium.org/2583103002
Cr-Commit-Position: refs/heads/master@{#463804}

[modify] https://crrev.com/f33387355ea2adb63f7be7bd58f819123f894e6c/tools/metrics/actions/actions.xml

Comment 5 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics
Components: UI>Browser>Mobile>TodayView
Today extension is deprecated. We will remove metrics.

Sign in to add a comment