New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675349 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Undefined-shift in WebRtcSpl_LevinsonDurbin

Project Member Reported by ClusterFuzz, Dec 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5324054639935488

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcSpl_LevinsonDurbin
  webrtc::Expand::AnalyzeSignal
  webrtc::Expand::Process
  

Minimized Testcase (1.95 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95kcYxHuzucS00Qok4y43IRk45m5c37tPjQWnj_EfLOtZ117ROCSQNrLgc2TkE3C_zrFI0Wy8TOw4TYVnXju3PpN0Rw9GWfYEH6rmjFvum6atcrm8UD5I9z9-DPzrU7TXVv4JY6t1rxiqe7K4CXJDscBOhXHg?testcase_id=5324054639935488

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: tlegrand@chromium.org hlundin@chromium.org
Components: Blink>WebRTC>Audio
Owner: ivoc@chromium.org
Status: Assigned (was: Untriaged)
Ivo, please, take a look at this.
Labels: -OS-Linux OS-All
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/abf1752ff44481cff17b5bfada8e18bf537fe27d

commit abf1752ff44481cff17b5bfada8e18bf537fe27d
Author: ivoc <ivoc@webrtc.org>
Date: Tue Jan 10 11:37:20 2017

Fix for left shift of potentially negative value.

Left shifting of negative integers is undefined behavior, and should be prevented. This CL fixes one such instance in the Levinson Durbin function.

BUG= chromium:675349 

Review-Url: https://codereview.webrtc.org/2621693002
Cr-Commit-Position: refs/heads/master@{#15984}

[modify] https://crrev.com/abf1752ff44481cff17b5bfada8e18bf537fe27d/webrtc/common_audio/signal_processing/levinson_durbin.c

Project Member

Comment 4 by ClusterFuzz, Jan 13 2017

ClusterFuzz has detected this issue as fixed in range 443187:443210.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5324054639935488

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcSpl_LevinsonDurbin
  webrtc::Expand::AnalyzeSignal
  webrtc::Expand::Process
  
Sanitizer: undefined (UBSAN)

Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=443187:443210

Minimized Testcase (1.95 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95kcYxHuzucS00Qok4y43IRk45m5c37tPjQWnj_EfLOtZ117ROCSQNrLgc2TkE3C_zrFI0Wy8TOw4TYVnXju3PpN0Rw9GWfYEH6rmjFvum6atcrm8UD5I9z9-DPzrU7TXVv4JY6t1rxiqe7K4CXJDscBOhXHg?testcase_id=5324054639935488

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: M-57
Project Member

Comment 6 by ClusterFuzz, Jan 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5324054639935488 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment