New issue
Advanced search Search tips

Issue 675344 link

Starred by 2 users
Status: Fixed
Owner:
leon....@intel.com
Closed: Dec 2016
Cc:
boliu@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Typing miss in DisplayAndroid.java

Project Member Reported by leon....@intel.com, Dec 17 2016 
In ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java, DisplayAndroid::stopAccurateListening() should not call
DisplayAndroidManager::startAccurateListening(). 

It should be DisplayAndroidManager::stopAccurateListening().
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9075d62cd418b457848ef6a3c51a0163eee6d068

commit 9075d62cd418b457848ef6a3c51a0163eee6d068
Author: leon.han <leon.han@intel.com>
Date: Sat Dec 17 11:42:03 2016

Fix DisplayAndroid.java.

DisplayAndroid::stopAccurateListening() should not call
DisplayAndroidManager::startAccurateListening().

BUG= 675344 

Review-Url: https://codereview.chromium.org/2581113003
Cr-Commit-Position: refs/heads/master@{#439338}

[modify] https://crrev.com/9075d62cd418b457848ef6a3c51a0163eee6d068/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java

Comment 2 by leon....@intel.com, Dec 17 2016

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Dec 17 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 17 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28bddc79a54f81c038164fcb8769ec500f81f9ea

commit 28bddc79a54f81c038164fcb8769ec500f81f9ea
Author: Han Leon <leon.han@intel.com>
Date: Sat Dec 17 12:51:07 2016

[M56] Fix DisplayAndroid.java.

DisplayAndroid::stopAccurateListening() should not call
DisplayAndroidManager::startAccurateListening().

BUG= 675344 
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2581113003
Cr-Commit-Position: refs/heads/master@{#439338}
(cherry picked from commit 9075d62cd418b457848ef6a3c51a0163eee6d068)

Review-Url: https://codereview.chromium.org/2584153002 .
Cr-Commit-Position: refs/branch-heads/2924@{#535}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/28bddc79a54f81c038164fcb8769ec500f81f9ea/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java

Comment 5 by leon....@intel.com, Dec 19 2016

Status: Fixed (was: Started)
►

Sign in to add a comment