New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675336 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in gfx::ScaleToEnclosingRect

Project Member Reported by ClusterFuzz, Dec 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5665537154875392

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  gfx::ScaleToEnclosingRect
  cc::LayerImpl::PopulateScaledSharedQuadState
  cc::PictureLayerImpl::AppendQuads
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=438853:439175

Minimized Testcase (1.43 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96Zc1Tq9Bo6OzLlNDYm0BQFnnlBAeX5OyLu8tajmN45nzpkTOUfGJQkASjOb0sxkDMQWMSc-2VbmzAsrl29aYKd1TrscNW_EahiJ_yIobIeUPF9mIfs9EVihiYOY1kGGKMispcRyubeMjqlTANAsy-ohIyGzg?testcase_id=5665537154875392

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>Compositing
Labels: Test-Predator-Correct-CLs
Owner: xlai@chromium.org
Status: Assigned (was: Untriaged)
From Find it assigning to the concern owner --
The result is a list of CLs that change the crashed files. 

Author: xlai
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/5e87e713d6ed8c36fb37b814c6b65e7096d4554e
Time: Fri Dec 16 02:10:25 2016
Lines 187-191 of file layer_impl.cc which potentially caused crash are changed in this cl (frame #1, "cc::LayerImpl::PopulateScaledSharedQuadState"). 

Lines 205-206 of file picture_layer_impl.cc which potentially caused crash are changed in this cl (frame #2, "cc::PictureLayerImpl::AppendQuads").
Minimum distance from crash line to modified line: 0. (file: layer_impl.cc, crashed on: 187, modified: 187).

@xlai -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by xlai@chromium.org, Dec 20 2016

This is pretty weird. cc::PictureLayerImpl::AppendQuads eventually call the same function ScaleToEnclosingRect both before and after the CL. Are you sure this test case passes before the change?
Project Member

Comment 3 by ClusterFuzz, Dec 22 2016

ClusterFuzz has detected this issue as fixed in range 440242:440280.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5665537154875392

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  gfx::ScaleToEnclosingRect
  cc::LayerImpl::PopulateScaledSharedQuadState
  cc::PictureLayerImpl::AppendQuads
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=438853:439175
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=440242:440280

Minimized Testcase (1.43 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96Zc1Tq9Bo6OzLlNDYm0BQFnnlBAeX5OyLu8tajmN45nzpkTOUfGJQkASjOb0sxkDMQWMSc-2VbmzAsrl29aYKd1TrscNW_EahiJ_yIobIeUPF9mIfs9EVihiYOY1kGGKMispcRyubeMjqlTANAsy-ohIyGzg?testcase_id=5665537154875392

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Dec 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5665537154875392 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment