New issue
Advanced search Search tips

Issue 675319 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

minimum_chrome_version in a multi-embedder extensions world

Project Member Reported by michae...@chromium.org, Dec 17 2016

Issue description

Extension manifests can include a minimum_chrome_version key[1] to prevent installation on versions that don't support whatever behavior/features they need.[1]

Since this lives in //chrome, app_shell logs a WARNING:shell_extension_system.cc(63): Unrecognized manifest key 'minimum_chrome_version'.

It also doesn't validate the product version.

Technically, any target can have its own PRODUCT_VERSION.[2] In reality, app_shell and chrome both use //chrome/VERSION (this happens at build time)[3] and it's reasonable to assume that extensions dependent on a particular version of "chrome" would also be dependent on that version of other embedders of extensions -- like app_shell.

Do other targets or installation mechanisms come up with their own versioning schemes (see [4])? Should the minimum_chrome_version key be used anyway in those cases?

[1] https://developer.chrome.com/apps/manifest/minimum_chrome_version
[2] https://cs.chromium.org/search/?q=product_version+major+minor&sq=package:chromium&type=cs
[3] https://cs.chromium.org/chromium/src/build/util/BUILD.gn?q=%22chrome/version%22+file:build&sq=package:chromium&l=31&dr=C
[4] https://cs.chromium.org/search/?q=%22chrome_version_path%22&sq=package:chromium&type=cs
 
Owner: michae...@chromium.org
Status: Assigned (was: Untriaged)
michael, I think you're working on this and have a CL up?  Assigning to you to get it out of triage.

(IIRC, I commented on the CL and we're waiting for steel's feedback?)

Comment 2 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Comment 3 by st...@chromium.org, Mar 3 2017

Cc: -st...@chromium.org
Owner: benwells@chromium.org

Sign in to add a comment