click event not fired on tap of video element when controls is not present
Reported by
marius.k...@gmail.com,
Dec 17 2016
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: 1. create a <video> tag with no controls 2. add a click event listener 3. touch or emulate touch with chrome What is the expected behavior? click event should fire What went wrong? click event does not fire Did this work before? Yes I know for sure it worked in 52, not sure about 53 and 54 Does this work in other browsers? Yes Chrome version: 55.0.2883.87 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 24.0 r0 It works when touched rapidly, because the controls is then considered shown, even though controls are missing.
,
Dec 19 2016
Issue 675470 has been merged into this issue.
,
Dec 19 2016
Since i have bisected the issue 675470 , i am providing that bisect information here Able to reproduce this issue (675470) on windows 10, Ubuntu 14.04 and Mac 10.12.2 on latest chrome stable #55.0.2883.87, dev #57.0.2950.4 and Canary #57.0.2955.0 Issue is broken in M56. Note: ------ Even though issue is reproduced in #55.0.2883.87, but it is not seen in earlier versions M56 Bisect Info: =========== Good build : 56.0.2897.0, Revision Range-426673 Bad build : 56.0.2898.0, Revision Range-426930 After executing the per-revision-bisect script, i got the following CL's between good and bad build versions ============================================ https://chromium.googlesource.com/chromium/src/+log/0d42d6c0fa774d6682b6ca90edc90b14cb94de3d..ab5a1f3c40b48b2a0498e6469f9f8d676a728994 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/ab5a1f3c40b48b2a0498e6469f9f8d676a728994 From the above CL suspecting the below change -------------------------------------- Review-Url: https://chromiumcodereview.appspot.com/2368433002 xunjieli@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Please let me know for any further information. Thank You...
,
Dec 19 2016
This is not mine.
,
Dec 20 2016
,
Jan 3 2017
Yeah I can't see any way the above CL could possibly cause this issue. kkaluri@ would you mind attempting another bisect - perhaps something went wrong with the first one?
,
Jan 17 2017
Bisect Info: =========== Good build : 56.0.2896.0, Revision Range- 426358 Bad build : 56.0.2897.0, Revision Range- 426673 After executing the per-revision-bisect script, i got the following CL's between good and bad build versions ============================================ https://chromium.googlesource.com/chromium/src/+log/cfe43126e0716d7626175dd0c4cac9a12863a50b..cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2 From the above CL suspecting the below change -------------------------------------- Review-Url: https://chromiumcodereview.appspot.com/2431583004 mlamouri@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Thank You...
,
Jan 17 2017
,
Jan 18 2017
I have uploaded a CL fixing the issue when the native controls are not being used. In the case of native controls, this is less clear that what we are doing is incorrect and if it is, it is not really a regression as there are various pieces of the UI blocking events.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47fb183f3d579aed696376053b74e691618d3cf2 commit 47fb183f3d579aed696376053b74e691618d3cf2 Author: mlamouri <mlamouri@chromium.org> Date: Thu Jan 19 10:54:49 2017 Media Controls: do not handle any event if no controls should be visible. This is fixing a regression where a tap on a video without controls would not be received by the page. BUG= 675312 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2643723003 Cr-Commit-Position: refs/heads/master@{#444703} [add] https://crrev.com/47fb183f3d579aed696376053b74e691618d3cf2/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html [modify] https://crrev.com/47fb183f3d579aed696376053b74e691618d3cf2/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
,
Jan 19 2017
,
Jan 20 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL to branch 2924 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2017
Please merge your change to M56 ASAP, we are cutting Stable RC soon.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72f48baaff975055c0c934fbfc997b47685faafd commit 72f48baaff975055c0c934fbfc997b47685faafd Author: Mounir Lamouri <mlamouri@chromium.org> Date: Mon Jan 23 20:53:26 2017 Media Controls: do not handle any event if no controls should be visible. This is fixing a regression where a tap on a video without controls would not be received by the page. BUG= 675312 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2643723003 Cr-Commit-Position: refs/heads/master@{#444703} (cherry picked from commit 47fb183f3d579aed696376053b74e691618d3cf2) Review-Url: https://codereview.chromium.org/2648263004 . Cr-Commit-Position: refs/branch-heads/2924@{#845} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [add] https://crrev.com/72f48baaff975055c0c934fbfc997b47685faafd/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html [modify] https://crrev.com/72f48baaff975055c0c934fbfc997b47685faafd/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
,
Jan 23 2017
,
Jan 25 2017
Tested the issue on windows 10, Mac 10.12.2 and Ubuntu 14.04 using chrome beta version #56.0.2924.76 as per the merged issue: 675470 in Comment #2 and #3. Observed that click event got fired on tap of video element when control is not present. Note: Same behavior is also observed in the chrome reported version #55.0.2883.87 Attaching screen cast for reference. mlamouri@ - Could you please verify the screen cast and please let us know if it is the expected behavior. Thanks...!! |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by phistuck@chromium.org
, Dec 17 2016Status: Untriaged (was: Unconfirmed)