New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675304 link

Starred by 3 users
Status: Assigned
Owner:
qin...@chromium.org
Cc:
█ dfalcant...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Offline Pages] Click on "Download Completed" notification does not open the downloaded page

Project Member Reported by dim...@chromium.org, Dec 17 2016 
Chrome Dev 57.0.2950.3

When downloading pages, wait for a notification to become "Download Completed", then click on it. 

Expected: Download page opens, notification is dismissed.
Observed: Nothing opens, notification is dismissed.

This is a regression from M56. Verified M56 Beta 56.0.2924.23 which works correctly as expected.

Comment 1 by dfalcant...@chromium.org, Dec 19 2016

Cc: -fgor...@chromium.org -dfalcant...@chromium.org
Owner: dfalcant...@chromium.org
Status: Started (was: Untriaged)
Can take a look.

Comment 2 by dfalcant...@chromium.org, Dec 19 2016 

Looks like it might be related to https://codereview.chromium.org/2544633003.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42470b714cddfd0d017a0443ff8e29fdb0c26784

commit 42470b714cddfd0d017a0443ff8e29fdb0c26784
Author: dfalcantara <dfalcantara@chromium.org>
Date: Mon Dec 19 23:45:04 2016

[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304

Review-Url: https://codereview.chromium.org/2588933002
Cr-Commit-Position: refs/heads/master@{#439617}

[modify] https://crrev.com/42470b714cddfd0d017a0443ff8e29fdb0c26784/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Comment 4 by dfalcant...@chromium.org, Dec 20 2016

Cc: dfalcant...@chromium.org
Owner: qin...@chromium.org
Status: Assigned (was: Started)
This is fixed, but I'm assigning to Min because I'm not terribly happy about how I fixed it.

Comment 5 by qin...@chromium.org, Jan 3 2017 

Issue 670574 has been merged into this issue.
►

Sign in to add a comment