child_process_launcher.cc is filled with "#if defined"'s and should be cleaned-up where possible.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7 commit d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7 Author: jcivelli <jcivelli@chromium.org> Date: Thu Dec 22 03:51:41 2016 Making the ownership of parameters in BrowserChildProcessHost::Launch and ChildProcessLauncher::Launch() explicit. BUG= 675294 Review-Url: https://codereview.chromium.org/2585963002 Cr-Commit-Position: refs/heads/master@{#440333} [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/components/nacl/browser/nacl_broker_host_win.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/browser_child_process_host_impl.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/browser_child_process_host_impl.h [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/child_process_launcher.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/child_process_launcher.h [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/ppapi_plugin_process_host.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/browser/utility_process_host_impl.cc [modify] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/content/public/browser/browser_child_process_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6f55074f173bd0c45d96e98a7d747032ab786bb commit e6f55074f173bd0c45d96e98a7d747032ab786bb Author: jcivelli <jcivelli@chromium.org> Date: Fri Jan 06 19:29:12 2017 Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() First step in an effort to refactor content::ChildProcessLauncher, by unifying ContentBrowserClient::GetAdditionalMappedFilesForChildProcess() on Android and Linux by moving the region argument to content::FileDescriptorInfo. BUG= 675294 Review-Url: https://codereview.chromium.org/2613803003 Cr-Commit-Position: refs/heads/master@{#442007} [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/android_webview/browser/aw_content_browser_client.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/chromecast/browser/cast_content_browser_client.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/browser/android/child_process_launcher_android.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/browser/android/child_process_launcher_android.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/browser/battery_status/battery_monitor_integration_browsertest.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/browser/child_process_launcher.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/browser/file_descriptor_info_impl.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/browser/file_descriptor_info_impl.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/public/browser/content_browser_client.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/public/browser/file_descriptor_info.h [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/e6f55074f173bd0c45d96e98a7d747032ab786bb/content/shell/browser/shell_content_browser_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/828cd7f49f285857a741f6f255193ca6bbb011cd commit 828cd7f49f285857a741f6f255193ca6bbb011cd Author: jcivelli <jcivelli@chromium.org> Date: Wed Jan 18 19:50:46 2017 Unifying ChildProcessLauncher across platforms. Refactored ChildProcessLauncher in an attempt to unify the API across platforms and split the implementation in platform specific files, replacing the existing ifdef's spaghetti code. A new ref counted Helper class is added to ChildProcessLauncher that is used with the various posted tasks (ChildProcessLauncher is owned by the client code and can be destroyed at any point) and contains most of the platform specific code. In some cases, some minimal amount of code is duplicated in the platform specific files, but it keeps the code clearer and easier to follow. Non trivial shared code between Posix implementations is in child_process_launcher_posix.cc. BUG= 675294 Review-Url: https://codereview.chromium.org/2594203004 Cr-Commit-Position: refs/heads/master@{#444442} [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/BUILD.gn [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/android/child_process_launcher_android.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/android/child_process_launcher_android.h [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/browser_child_process_host_impl.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher.h [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper.cc [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper.h [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper_android.cc [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper_linux.cc [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper_mac.cc [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper_posix.cc [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper_posix.h [add] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/child_process_launcher_helper_win.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/file_descriptor_info_impl.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/file_descriptor_info_impl.h [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/file_descriptor_info_impl_unittest.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/public/browser/browser_message_filter.cc [modify] https://crrev.com/828cd7f49f285857a741f6f255193ca6bbb011cd/content/public/browser/file_descriptor_info.h
Comment 1 by bugdroid1@chromium.org
, Dec 22 2016