Tab switcher screenshots are incorrect on sites with interstitials |
||
Issue description
Application Version (from "Chrome Settings > About Chrome"): refs/heads/master@{#439145}
Steps to reproduce:
0.) Open two tabs, switch to one
1.) Navigate to https://badssl.com/
2.) Click on expired
3.) Go to tab switcher and click other tab
4.) Go back to tab switcher
Observed behavior:
You see the original page instead of the interstitial
Expected behavior:
You should see the interstitial
Frequency:
100%
Additional comments:
,
Dec 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eb9ee95588a470a55b89d6e65ab67b0fdaff802 commit 5eb9ee95588a470a55b89d6e65ab67b0fdaff802 Author: tedchoc <tedchoc@chromium.org> Date: Tue Dec 27 18:46:54 2016 Fix tab switcher screenshots for interstitials. In particular, interstitials "mask" the underlying webcontents and we need to handle them specially. We do this by capturing the correct content::RenderViewHost from the interstitial instead of the webcontents it sits on top of. BUG= 675283 Review-Url: https://codereview.chromium.org/2581413002 Cr-Commit-Position: refs/heads/master@{#440772} [modify] https://crrev.com/5eb9ee95588a470a55b89d6e65ab67b0fdaff802/chrome/browser/android/compositor/tab_content_manager.cc
,
Dec 27 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ainslie@chromium.org
, Dec 18 2016