New issue
Advanced search Search tips

Issue 675264 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 78507



Sign in to add a comment

Tracking bug for infrastructure changes to enable SQLite WAL mode.

Project Member Reported by sh...@chromium.org, Dec 16 2016

Issue description

Background: issue 78507 and https://www.sqlite.org/wal.html

This bug is about tracking changes to third_party/sqlite/ and sql/ to allow other code to make use of WAL mode.  For instance:
 - change SQLite checkpoint-on-close defaults.
 - sql::Connection API changes.
 - sql::Connection implementation changes.
 - sql::Recovery support.
 - sql::test:: support.
Basically, infrastructure changes without changes to how Chromium operates in production.
 

Comment 1 by sh...@chromium.org, Apr 18 2017

This CL: https://codereview.chromium.org/2587603003/
back-ported a SQLite change to control checkpoint-on-close.  I'm going to close it, because the current SQLite version in Chromium has the change already, so I'm just leaving it here for future generations, just in case.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7fcc45c7cfb05f8fed045d38153792baba57e89

commit f7fcc45c7cfb05f8fed045d38153792baba57e89
Author: shess <shess@chromium.org>
Date: Wed Apr 19 22:10:41 2017

[sql] Verify control of close-time WAL checkpoint.

SQLite WAL mode by default checkpoints the WAL to the main database at
close time.  Chromium closes databases at shutdown, which causes
shutdown slowdowns due to buffered data being flushed.  WAL
checkpointing would effectively increase the amount of buffered data
being flushed.

[WAL mode is currently not in use by Chromium.]

BUG=675264

Review-Url: https://codereview.chromium.org/2827673006
Cr-Commit-Position: refs/heads/master@{#465772}

[modify] https://crrev.com/f7fcc45c7cfb05f8fed045d38153792baba57e89/sql/connection.h
[modify] https://crrev.com/f7fcc45c7cfb05f8fed045d38153792baba57e89/sql/sqlite_features_unittest.cc

Comment 3 by sh...@chromium.org, Jun 21 2017

Labels: ShessReview

Comment 4 by jrobb...@google.com, Sep 21 2017

Owner: pwnall@chromium.org

Sign in to add a comment