Issue 675262 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ nxia@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Cc:	akes...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

git fetch should retry on 'Connection refused' error

Project Member Reported by nxia@chromium.org, Dec 16 2016

Issue description

11:06:51: INFO: RunCommand: git fetch -f https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay refs/changes/86/420986/2 in /b/cbuild/internal_master/src/third_party/chromiumos-overlay

[1;31m11:06:52: ERROR: <class 'chromite.lib.cros_build_lib.RunCommandError'>: return code: 128; command: git fetch -f https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay refs/changes/86/420986/2
fatal: unable to access 'https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay/': Failed connect to chromium-review.googlesource.com:443; Connection refused

cmd=['git', 'fetch', '-f', u'https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay', u'refs/changes/86/420986/2'], cwd=/b/cbuild/internal_master/src/third_party/chromiumos-overlay
Traceback (most recent call last):
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/failures_lib.py", line 172, in wrapped_functor
    return functor(*args, **kwargs)
  File "/b/build/slave/monroe-paladin-master/build/chromite/cbuildbot/stages/sync_stages.py", line 783, in PerformStage
    self.ManifestCheckout(new_manifest)
  File "/b/build/slave/monroe-paladin-master/build/chromite/cbuildbot/stages/sync_stages.py", line 1123, in ManifestCheckout
    self.pool.ApplyPoolIntoRepo()
  File "/b/build/slave/monroe-paladin-master/build/chromite/cbuildbot/validation_pool.py", line 1776, in ApplyPoolIntoRepo
    patch_series.ApplyChange(change, manifest=manifest)
  File "/b/build/slave/monroe-paladin-master/build/chromite/cbuildbot/validation_pool.py", line 394, in f
    return functor(self, *args, **kwargs)
  File "/b/build/slave/monroe-paladin-master/build/chromite/cbuildbot/validation_pool.py", line 427, in ApplyChange
    return change.ApplyAgainstManifest(self.manifest, trivial=False)
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/patch.py", line 1123, in ApplyAgainstManifest
    trivial=trivial)
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/patch.py", line 1061, in Apply
    self.Fetch(git_repo)
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/patch.py", line 931, in Fetch
    mon_fields=fields)
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/git.py", line 805, in RunGit
    ['git'] + cmd, **kwargs)
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/retry_util.py", line 122, in GenericRetry
    ret = functor(*args, **kwargs)
  File "/b/build/slave/monroe-paladin-master/build/chromite/lib/cros_build_lib.py", line 625, in RunCommand
    raise RunCommandError(msg, cmd_result)
RunCommandError: return code: 128; command: git fetch -f https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay refs/changes/86/420986/2
fatal: unable to access 'https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay/': Failed connect to chromium-review.googlesource.com:443; Connection refused

cmd=['git', 'fetch', '-f', u'https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay', u'refs/changes/86/420986/2'], cwd=/b/cbuild/internal_master/src/third_party/chromiumos-overlay





https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromeos%2Fmonroe-paladin%2F11803%2F%2B%2Frecipes%2Fsteps%2FCommitQueueSync%2F0%2Fstdout

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/72f9031ce597782c2282cf203f4150c74b34739a

commit 72f9031ce597782c2282cf203f4150c74b34739a
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Dec 16 23:40:02 2016

Retry git fetch on 'Connection refused' error.

BUG= chromium:675262 
TEST=run_tests

Change-Id: I9567e7ecc5a87b78dde1445175bbb394db118e1e
Reviewed-on: https://chromium-review.googlesource.com/421144
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/72f9031ce597782c2282cf203f4150c74b34739a/lib/git.py