New issue
Advanced search Search tips

Issue 675245 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up chrome/browser/ssl dependencies on safe_browsing

Project Member Reported by est...@chromium.org, Dec 16 2016

Issue description

Over time chrome/browser/ssl has grown a few dependencies on safe_browsing, mostly related to certificate reporting, which is a little weird. We should clean these up if we can, for example by passing in callbacks from ChromeContentBrowserClient.
 

Comment 1 by mea...@chromium.org, Dec 16 2016

Do we want to clean up all dependencies on safe browsing, or only the ones to chrome/browser/safe_browsing? I think there is only one non-test dependency on c/b/sb and that should be gone with crrev/2503243003. The rest seem to be depending on the safe browsing component instead.

Or do we also want to do clean up all dependencies, even for tests?

Also I think there is an other option: move most (all?) of the reporting code to safebrowsing. I haven't yet checked how feasible this is.

Comment 2 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 3 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment