Issue 675243 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ nxia@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Cc:	akes...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Repo sync on local manifest path added entries in Mornach

Project Member Reported by nxia@chromium.org, Dec 16 2016

Issue description

repo sync on local manifest path added entries in Mornach. this is a local sync and shouldn't be recorded in Mornach. 

Add a helper method to filter out metrics of repo sync on local manifest_repo_url.


http://shortn/_jiWJsKK7mS

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c2e97343c61d682b951d0e23ba0a13f72f25b0d1

commit c2e97343c61d682b951d0e23ba0a13f72f25b0d1
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Dec 16 23:08:33 2016

Skip recording metrics for repo.sync on local manifest path.

Shouldn't increment repo_sync_count counter when repo syncs on a local
manifest path.

BUG= chromium:675243 
TEST=unit_tests

Change-Id: I4c221f4afdc80f670a4752054e17b52ce7fbe7eb
Reviewed-on: https://chromium-review.googlesource.com/422054
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/c2e97343c61d682b951d0e23ba0a13f72f25b0d1/cbuildbot/repository.py
[modify] https://crrev.com/c2e97343c61d682b951d0e23ba0a13f72f25b0d1/cbuildbot/repository_unittest.py