New issue
Advanced search Search tips

Issue 675240 link

Starred by 1 user
Status: WontFix
Owner:
pasko@chromium.org
Closed: Aug 2017
Cc:
droger@chromium.org
battre@chromium.org
mattcary@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Disabling "Use a prediction service to load pages more quickly" Doesn't Take Effect Until Restart

Project Member Reported by mpear...@chromium.org, Dec 16 2016 

In Chrome settings, if I disable the checkbox "Use a prediction service to load pages more quickly", I don't think it takes effect until restart.

Here's why I think this is the case:
On a clean profile, I typed internalsite/foo in the omnibox, noticed it defaulted to search, and return.  I did not see a "Did you mean to go to URL?" infobar.  This is consistent with  bug 247848 , where prerendering/preloading ends up disabling this infobar.  I went into settings and unselected this checkbox.  I tried to go to another site: otherinternalsite/foo in the omnibox.  Again I did not see an infobar.

After restarting, I could go to other thirdinternalsite/foo and get the infobar.

If I change the order of these internal sites, I see the same behavior.  (i.e., it's not an issue with the particular sites; each would cause a Did-you-mean if the settings were right.)

If we're keeping this feature, we either need make disabling work instantly or at least clarify the messaging around it.

Comment 1 by pasko@chromium.org, Dec 19 2016

Cc: droger@chromium.org mattcary@chromium.org
We are checking this pref on prerender start, and don't seem to cache it anywhere:
https://codesearch.chromium.org/chromium/src/chrome/browser/prerender/prerender_manager.cc?sq=package:chromium&dr=C&rcl=1482135521&l=1329

Could it be that a prerender already started before you modified the pref, and then something decided to reuse this prerender for this otherinternalsite/foo? Unlikely, but .. can you check the same scenario, and kill all prerenders in the task manager after tweaking the checkbox?

There are of course some layers that could potentially reset the pref until the restart, my reasoning is only about PrerenderManager and what is below the stack from it.

Comment 2 by mpear...@chromium.org, Dec 19 2016 

If I disable the checkbox, then manually kill the prerenderer, upon next the next attempted navigation to an internal site (that results in a search results page), I see the "did you mean?" message.

Comment 3 by pasko@chromium.org, Dec 20 2016

Cc: battre@chromium.org
nice! do you think Chrome should kill prerenders on the prefs switch or it's fine if old predictions continue working in the background?

+battre

Comment 4 by battre@chromium.org, Dec 20 2016 

My position would be that a pref change should either be effective immediately or we should tell the user that they need to restart Chrome (which is a bit difficult on Android).

Comment 5 by pasko@chromium.org, Dec 20 2016 

my understanding of this bug is that restarting the browser is not required, but a live prerender can continue sending requests for 5 minutes at most.

Comment 6 by pasko@chromium.org, Aug 16 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment