New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 571533
issue 675239



Sign in to add a comment

Remove SetSelectedTab() from WebsiteSettings

Project Member Reported by lgar...@chromium.org, Dec 16 2016

Issue description

Very deprecated and unused.
 
Blocking: 675239

Comment 2 Deleted

Status: Fixed (was: fe)
Status: Started (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ce627c8aa95544706c84a918170a8e53f5a20e

commit 53ce627c8aa95544706c84a918170a8e53f5a20e
Author: lgarron <lgarron@chromium.org>
Date: Thu Jan 05 21:09:17 2017

Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

This gets rid of the remaining call to SetSelectedTab(), which has no effect on any platforms anymore.

BUG= 646465 ,  571533 ,  675239 ,  675238 

Review-Url: https://codereview.chromium.org/2521173004
Cr-Commit-Position: refs/heads/master@{#441749}

[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/android/page_info/connection_info_popup_android.cc
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/android/page_info/connection_info_popup_android.h
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/android/page_info/website_settings_popup_android.cc
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/android/page_info/website_settings_popup_android.h
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/website_settings/website_settings.h
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/website_settings/website_settings_ui.h
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/chrome/browser/ui/website_settings/website_settings_unittest.cc
[modify] https://crrev.com/53ce627c8aa95544706c84a918170a8e53f5a20e/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment