New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675228 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 578344



Sign in to add a comment

rewrite_to_chrome_style: toV8 sometimes gets to ToV8 and sometimes doesn't

Project Member Reported by lukasza@chromium.org, Dec 16 2016

Issue description

toV8 is a function that is overloaded for lots of various argument types.

Let's say that we have an invocation to this function from non-generated code.  If the resolved overload comes from generated code, then the callsite won't get renamed to |ToV8|, otherwise it will be stay named as |toV8|.
 

Comment 1 by dcheng@chromium.org, Dec 17 2016

Would it help to convert this one ahead of time?
Labels: -Pri-3 Pri-1
RE: #c1

I've put together an ahead-of-time conversion at https://codereview.chromium.org/2595543003
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4367352829a637bf5f3c7831c5e43f1d362d52d7

commit 4367352829a637bf5f3c7831c5e43f1d362d52d7
Author: lukasza <lukasza@chromium.org>
Date: Thu Jan 05 01:53:23 2017

Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG= 675228 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2595543003
Cr-Commit-Position: refs/heads/master@{#441555}

[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/Iterable.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/Maplike.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ToV8.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8BindingTest.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/modules/v8/WebGLAny.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/scripts/v8_types.py
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/templates/union_container.h.tmpl
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/dom/DOMDataView.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/dom/DOMTypedArray.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/events/MessageEvent.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/streams/ReadableStreamController.h
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/web/WebBlob.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
[modify] https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Status: Fixed (was: Untriaged)

Comment 5 by thakis@chromium.org, Apr 17 2017

Owner: lukasza@chromium.org

Sign in to add a comment