New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Enable download page action for offline dino page

Project Member Reported by talo@chromium.org, Dec 16 2016

Issue description

We should enable the page download action for the offline dino page. This should trigger the same downloading flow as the 'download page later' button.
 

Comment 1 by dim...@chromium.org, Dec 17 2016

Owner: jianli@chromium.org
Status: Assigned (was: Untriaged)
Jian, could you take a look at it? Thanks!

Comment 2 by dim...@chromium.org, Dec 19 2016

Also, the button in 3-dot menu should not get disabled when download is initiated. This is purposefully different from the big blue button on the dino page itself, which does get disabled when it happens.

Comment 3 by dim...@chromium.org, Dec 19 2016

Labels: -Pri-3 Pri-2

Comment 4 by jianli@chromium.org, Dec 19 2016

Should we enable Download button when the error page only contains "Reload" button for certain types of errors? I assume we want to be consistent with when to show "DOWNLOAD PAGE LATER" in error page.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0fe12b996f99d984f92983d188b7095b8c80134

commit b0fe12b996f99d984f92983d188b7095b8c80134
Author: jianli <jianli@chromium.org>
Date: Thu Jan 12 01:14:08 2017

Enable download page action for error page

If error page shows "DOWNLOAD PAGE LATER" button, we should also
enable download page action.

BUG= 675225 

Patch

Review-Url: https://codereview.chromium.org/2588253002
Cr-Commit-Position: refs/heads/master@{#443104}

[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/android/offline_pages/offline_page_bridge.h
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/net/net_error_tab_helper.cc
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/browser/net/net_error_tab_helper_unittest.cc
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/common/render_messages.h
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/components/error_page/renderer/net_error_helper_core.cc
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/components/error_page/renderer/net_error_helper_core.h
[modify] https://crrev.com/b0fe12b996f99d984f92983d188b7095b8c80134/components/error_page/renderer/net_error_helper_core_unittest.cc

Comment 7 by jianli@chromium.org, Jan 12 2017

Status: Fixed (was: Started)

Sign in to add a comment