New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675209 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in SkPixmap::erase

Project Member Reported by ClusterFuzz, Dec 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6603496993587200

Fuzzer: inferno_canvas_wrecker
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x0002a9d1d000
Crash State:
  SkPixmap::erase
  SkBitmap::eraseColor
  SkPictureImageGenerator::onGetPixels
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=436783:436847

Minimized Testcase (0.67 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96NflOkGsm9Cd2cPL2sZBvXhI6Fp2vCGVQlmsFJnVwBbXS9rVcocFR_khmDOASvx47i-D9Wq67d4quoCVAVyQoTGp9tJnpEGISvCn22oQJbcXu9RxOZjgb5bYXSO0isScH3sV61p4ED3Ru_6Wvs3wvhnJ2Utw?testcase_id=6603496993587200

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 17 2016

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 17 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 17 2016

Labels: Pri-1
Components: Internals>Skia
Owner: reed@chromium.org
Status: Assigned (was: Untriaged)
Can you please take a look or assign to someone who can? Thanks.
Owner: bsalomon@chromium.org
Cc: fmalita@chromium.org bsalomon@chromium.org
Owner: reed@google.com

Comment 7 by reed@google.com, Dec 22 2016

This appears to be over-committed memory allocation, so we crash after the allocation, as we attempt to write to a new page (see that the crash address is on a 4K page boundary).

What is the command-line to run the minimal testcase?
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 5 2017

reed: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 19 2017

reed: Uh oh! This issue still open and hasn't been updated in the last 28 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

A friendly reminder that M57 Beta launch is coming soon on February 2nd! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Dev (before Beta promotion). Thank you!
Project Member

Comment 11 by ClusterFuzz, Jan 25 2017

ClusterFuzz has detected this issue as fixed in range 445725:445853.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6603496993587200

Fuzzer: inferno_canvas_wrecker
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x0002a9d1d000
Crash State:
  SkPixmap::erase
  SkBitmap::eraseColor
  SkPictureImageGenerator::onGetPixels
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=436783:436847
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=445725:445853

Minimized Testcase (0.67 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96NflOkGsm9Cd2cPL2sZBvXhI6Fp2vCGVQlmsFJnVwBbXS9rVcocFR_khmDOASvx47i-D9Wq67d4quoCVAVyQoTGp9tJnpEGISvCn22oQJbcXu9RxOZjgb5bYXSO0isScH3sV61p4ED3Ru_6Wvs3wvhnJ2Utw?testcase_id=6603496993587200

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jan 25 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6603496993587200 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 25 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta -M-57 M-58
Project Member

Comment 15 by sheriffbot@chromium.org, May 3 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment