Integer-overflow in blink::IntPoint::move |
||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6160001220739072 Fuzzer: ifratric-browserfuzzer-v3 Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::IntPoint::move blink::operator+= move Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=435261:438085 Minimized Testcase (0.53 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94Oi8lyANBLZ1VMHIxyJ9LmDh0DDrAiRYXlTNLoCjjMTp0U3WJ5_UF2p7Q-sAPonml-6jgdGJgirPTwNunRDsppnC98Us29x-hC2OnFOR7dCEvs79UJH-gchJd7RS1N0jRO58PEhX4zYGx9D453e6l8RQwpAg?testcase_id=6160001220739072 Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Dec 31 2016
schenney@, could you PTAL? My change (mentioned in #c1 above) only renamed some identifiers and shouldn't have caused any behavior changes. Maybe somebody from third_party/WebKit/Source/core/paint/OWNERS can take a look - I guess one of the first things to do would be to assess what is the desired behavior when blink::IntPoint::move hits an integer behavior (clip to max value maybe?).
,
Jan 3 2017
It should clip to max, I think. But I thought we had shifted to saturated arithmetic for all this code. pdr@, do you know the status?
,
Jan 3 2017
I had originally pushed for fixing this in IntPoint but it was clear that wasn't the best solution after all. Elliott, Walter, myself, Ojan and chrishtr chatted about this ~2 months ago and came to the following conclusions: * int overflow is not innately considered a security risk. * the worst case resulting from overflow in paint code is typically unsightly painting which is not (at least currently) sufficient to prompt code rework with maintenance/performance overhead. * decision on whether to fix should be made on a case by case basis by those who are intimately familiar with ramifications of what would happen in their area of the code base with over/underflow.
,
Feb 17 2017
I also looked into this and I believe it is safe. I don't think we need to fix this one. |
||||
►
Sign in to add a comment |
||||
Comment 1 by mummare...@chromium.org
, Dec 20 2016Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)