New issue
Advanced search Search tips

Issue 675124 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to blink::LayoutBox from blink::LayoutRubyAsInline;blink::LayoutObject::isRubyRun;blink::LayoutRubyAsInline::addChild

Project Member Reported by ClusterFuzz, Dec 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5188038243385344

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x7f3ece069fd8
Crash State:
  Bad-cast to blink::LayoutBox from blink::LayoutRubyAsInline
  blink::LayoutObject::isRubyRun
  blink::LayoutRubyAsInline::addChild
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=437599:437697

Minimized Testcase (0.28 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95jgoq_PwOHCJmbylA68qWPI5ct1cO9prxtbtg6H3CcTevKKw7MfgwK_OEsPKwiZJK6OBAUoWB229QwQ4JDZ890ayymnBGU5lj_roPBtIVgLGVM8DPMWYZOshfr_0SD2oizFEJr31IUO-tgRuK_dhCtCU2_uA?testcase_id=5188038243385344

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 17 2016

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 17 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 17 2016

Labels: Pri-1
Components: Blink>Layout>Ruby Blink>Layout
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
Hi kojii@, can you take a look at this / retriage as necessary in the CSS Ruby layout module?

Comment 5 by kojii@chromium.org, Dec 22 2016

Cc: kojii@chromium.org
Labels: OS-Windows
Owner: chrishtr@chromium.org
Chris, could you help me to find someone familiar with -webkit-clip-path?

In CompositedLayerMapping::updateChildClippingMaskLayerGeometry() and a few other places, toLayoutBox(layoutObject()) fails because LayoutRubyAsInline is not LayoutBox.

The test still hits the same problem when I changed <ruby> to <span> by calling toLayoutBox() on LayoutInline.

I'm not sure if we're supposed to create layers for LayoutInline. Suppressing it may fix the problem but the spec says -webkit-clip-path applies to all elements. If the root cause is in layout code, I'm happy to look further, inline/ruby are my favorites, but having advises from clip-path experts would help.
Seems like this is very similar to https://bugs.chromium.org/p/chromium/issues/detail?id=675176.  Stacks very close, just slightly different at the top.

Feel free to combine if you agree.

Project Member

Comment 7 by ClusterFuzz, Dec 28 2016

ClusterFuzz has detected this issue as fixed in range 440808:440829.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5188038243385344

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x7f3ece069fd8
Crash State:
  Bad-cast to blink::LayoutBox from blink::LayoutRubyAsInline
  blink::LayoutObject::isRubyRun
  blink::LayoutRubyAsInline::addChild
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=437599:437697
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=440808:440829

Minimized Testcase (0.28 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95jgoq_PwOHCJmbylA68qWPI5ct1cO9prxtbtg6H3CcTevKKw7MfgwK_OEsPKwiZJK6OBAUoWB229QwQ4JDZ890ayymnBGU5lj_roPBtIVgLGVM8DPMWYZOshfr_0SD2oizFEJr31IUO-tgRuK_dhCtCU2_uA?testcase_id=5188038243385344

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 28 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5188038243385344 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 28 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 5 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment