Issue metadata
Sign in to add a comment
|
Float-cast-overflow in blink::BaseRenderingContext2D::drawImage |
||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=5186061518241792 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Float-cast-overflow Crash Address: Crash State: blink::BaseRenderingContext2D::drawImage drawImage3Method drawImageMethod Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=435261:438085 Minimized Testcase (0.72 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96STcemol2-hCjgvhL2_oYsWiZ0seHz6o2NwZTzu2DYVDp7nBp6QR-wSDPgsEGgJGV_6PUFFuxWESA1uUDmCPSJgUAzkeqKvV8JKBPKtTRir-ZtLpRsPjMoeE-X9VGc6G2EkJTCa_D1UvCRKousvCUgibr2hQ?testcase_id=5186061518241792 Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Dec 21 2016
This is a 2 week bisect range, which is not a useful range -- no human who values their time will go through 3 thousand patches to find a culprit.
That patch modified a different function in the same file, and is certainly not the cause of the problem.
So, the attribution is wrong. But, I've already sunk a while into reproducing this, so I might as well fix it.
The code that is failing is:
if (!std::isfinite(dx) || !std::isfinite(dy) || !std::isfinite(dw) ||
!std::isfinite(dh) || !std::isfinite(sx) || !std::isfinite(sy) ||
!std::isfinite(sw) || !std::isfinite(sh) || !dw || !dh || !sw || !sh)
return;
FloatRect srcRect = normalizeRect(FloatRect(sx, sy, sw, sh));
Umm, shouldn't we be checking that the cast to float would be safe?
,
Dec 21 2016
,
Dec 22 2016
ClusterFuzz has detected this issue as fixed in range 440242:440280. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5186061518241792 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Float-cast-overflow Crash Address: Crash State: blink::BaseRenderingContext2D::drawImage drawImage3Method drawImageMethod Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=435261:438085 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=440242:440280 Minimized Testcase (0.72 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96STcemol2-hCjgvhL2_oYsWiZ0seHz6o2NwZTzu2DYVDp7nBp6QR-wSDPgsEGgJGV_6PUFFuxWESA1uUDmCPSJgUAzkeqKvV8JKBPKtTRir-ZtLpRsPjMoeE-X9VGc6G2EkJTCa_D1UvCRKousvCUgibr2hQ?testcase_id=5186061518241792 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Dec 21 2016Labels: Test-Predator-Correct-CLs
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)