Issue metadata
Sign in to add a comment
|
Integer-overflow in blink::CSSSelector::RareData::matchNth |
||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=5101012777172992 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::CSSSelector::RareData::matchNth blink::SelectorChecker::checkPseudoClass blink::SelectorChecker::matchSelector Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=433807:433985 Minimized Testcase (0.32 Kb): Download: https://cluster-fuzz.appspot.com/download/AMIfv96xhRgGhWSLagM_ZZoKLtBZqZqeQwNf_L9B97e1xPPlsuCgnZnTEIUBqdBkKifnVZ1uRIwnUR1JDmWAPg2fyJBsJZOpVUsmr1WCP1bxvtdS3Fl7kvZQlTK_XdIrFBLR2U18A9MlPDHfxf3ltWqU9R9qEse7Xg?testcase_id=5101012777172992 <style> .c18:nth-last-of-type(51n-2147483647) { justify-self: left;</style><script> var docElement = document.body ? document.body : document.documentElement; tCF15 = document.createElementNS("http://www.w3.org/1998/Math/MathML", "annotation-xml"); docElement.appendChild(tCF15); tCF15.setAttribute("class", "c18"); </script> Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Feb 7 2017
schenney@ - I wonder if I can reassign to you (this is somewhat similar to issue 675139 or issue 683650 ). FWIW, I think that the CL pointed out in #c1 shouldn't cause any behavior change.
,
Feb 13 2017
Hey schenney@, Are you working on this? It seems like we could just fail fast on very large numbers. I attempted to fix something very similar in https://codereview.chromium.org/2191253002/
,
Feb 13 2017
meade@, I'm not working on this and I agree the best thing is to fail fast when asked to handle big numbers in cases where one normally wouldn't want them.
,
Feb 22 2017
,
Apr 4 2017
meade: Ping. Any update here?
,
Apr 10 2017
,
Apr 12 2017
,
Apr 12 2017
Converted label to hotlist
,
Apr 21 2017
CL up and in progress: https://codereview.chromium.org/2825993002
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/111fffdac5769c2358cd7e1d272529bbcca41700 commit 111fffdac5769c2358cd7e1d272529bbcca41700 Author: meade <meade@chromium.org> Date: Thu May 11 10:19:16 2017 Prevent integer overflows in ANPlusB handling BUG= 675112 Review-Url: https://codereview.chromium.org/2825993002 Cr-Commit-Position: refs/heads/master@{#470899} [modify] https://crrev.com/111fffdac5769c2358cd7e1d272529bbcca41700/third_party/WebKit/Source/core/css/CSSSelector.cpp [modify] https://crrev.com/111fffdac5769c2358cd7e1d272529bbcca41700/third_party/WebKit/Source/core/css/CSSSelector.h [modify] https://crrev.com/111fffdac5769c2358cd7e1d272529bbcca41700/third_party/WebKit/Source/core/css/CSSSelectorTest.cpp [modify] https://crrev.com/111fffdac5769c2358cd7e1d272529bbcca41700/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp [modify] https://crrev.com/111fffdac5769c2358cd7e1d272529bbcca41700/third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
,
May 12 2017
ClusterFuzz has detected this issue as fixed in range 470772:470990. Detailed report: https://clusterfuzz.com/testcase?key=5101012777172992 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::CSSSelector::RareData::matchNth blink::SelectorChecker::checkPseudoClass blink::SelectorChecker::matchSelector Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=433807:433985 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=470772:470990 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5101012777172992 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
May 12 2017
ClusterFuzz testcase 5101012777172992 is verified as fixed, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
May 12 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Jan 18 2017Components: Blink>CSS
Labels: -Type-Bug Test-Predator-Wrong M-57 Type-Bug-Regression
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)