New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675112 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Not working on Chrome any more
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Stylimations-OKR-2017-Q2


Sign in to add a comment

Integer-overflow in blink::CSSSelector::RareData::matchNth

Project Member Reported by ClusterFuzz, Dec 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5101012777172992

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::CSSSelector::RareData::matchNth
  blink::SelectorChecker::checkPseudoClass
  blink::SelectorChecker::matchSelector
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=433807:433985

Minimized Testcase (0.32 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96xhRgGhWSLagM_ZZoKLtBZqZqeQwNf_L9B97e1xPPlsuCgnZnTEIUBqdBkKifnVZ1uRIwnUR1JDmWAPg2fyJBsJZOpVUsmr1WCP1bxvtdS3Fl7kvZQlTK_XdIrFBLR2U18A9MlPDHfxf3ltWqU9R9qEse7Xg?testcase_id=5101012777172992
<style>
.c18:nth-last-of-type(51n-2147483647) { justify-self: left;</style><script>
var docElement = document.body ? document.body : document.documentElement;
tCF15 = document.createElementNS("http://www.w3.org/1998/Math/MathML", "annotation-xml");
docElement.appendChild(tCF15);
tCF15.setAttribute("class", "c18");
</script>


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: brajkumar@chromium.org
Components: Blink>CSS
Labels: -Type-Bug Test-Predator-Wrong M-57 Type-Bug-Regression
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
Find it and CL did not provide any possible suspect.
Using code search for file "SelectorChecker.cpp" from line #12 and suspecting the below change
Review URL: https://codereview.chromium.org/2588103003

lukasza@ - Observed some recent changes on this file so assigning to you, could you please check if this is caused with respect to your change, if not please help us in reassign the issue to the right owner.

Thanks!
Owner: schenney@chromium.org
schenney@ - I wonder if I can reassign to you (this is somewhat similar to  issue 675139  or  issue 683650 ).  FWIW, I think that the CL pointed out in #c1 shouldn't cause any behavior change.

Comment 3 by meade@chromium.org, Feb 13 2017

Cc: meade@chromium.org
Labels: Update-Weekly
Hey schenney@,

Are you working on this? It seems like we could just fail fast on very large numbers.
I attempted to fix something very similar in https://codereview.chromium.org/2191253002/


Cc: schenney@chromium.org
Owner: ----
Status: Available (was: Assigned)
meade@, I'm not working on this and I agree the best thing is to fail fast when asked to handle big numbers in cases where one normally wouldn't want them.

Comment 5 by meade@chromium.org, Feb 22 2017

Owner: meade@chromium.org
Status: Assigned (was: Available)

Comment 6 by suzyh@chromium.org, Apr 4 2017

meade: Ping. Any update here?

Comment 7 by suzyh@chromium.org, Apr 10 2017

Labels: Regressed-57

Comment 8 by suzyh@chromium.org, Apr 12 2017

Labels: Stylimations-OKR-2017-Q2

Comment 9 by suzyh@chromium.org, Apr 12 2017

Labels: -Stylimations-OKR-2017-Q2
Converted label to hotlist

Comment 10 by meade@chromium.org, Apr 21 2017

CL up and in progress: https://codereview.chromium.org/2825993002
Project Member

Comment 12 by ClusterFuzz, May 12 2017

ClusterFuzz has detected this issue as fixed in range 470772:470990.

Detailed report: https://clusterfuzz.com/testcase?key=5101012777172992

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::CSSSelector::RareData::matchNth
  blink::SelectorChecker::checkPseudoClass
  blink::SelectorChecker::matchSelector
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=433807:433985
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=470772:470990

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5101012777172992


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, May 12 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5101012777172992 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 14 by r...@opera.com, May 12 2017

Cc: msrchandra@chromium.org r...@opera.com
 Issue 721626  has been merged into this issue.

Sign in to add a comment