New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675099 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in blink::HTMLCanvasElement::getSourceImageForCanvas

Project Member Reported by ClusterFuzz, Dec 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4974507636031488

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00000000
Crash State:
  blink::HTMLCanvasElement::getSourceImageForCanvas
  blink::HTMLCanvasElement::getSourceImageForCanvas
  blink::BaseRenderingContext2D::drawImage
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=434678:434769

Minimized Testcase (23.27 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96YEFtT4fwoE5_ffenGe4Eb-9RJYkoKHSE0XMLDLyJ3DgKBMeWX2QG16T7FKFTm8yGwmlQA3-O3TD8dvQK9vHMn8AW6-g_-dlZZ3jDDzGSBJoP7B31sElOJtTMhe0lmF3vUhFy_AxZxeCywyQEbXF1BhIfKcFfVIUd97EbKUYTGTwHZ6-s?testcase_id=4974507636031488

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Blink>HTML
Labels: Test-Predator-Wrong-CLs
Owner: xlai@chromium.org
Status: Assigned (was: Untriaged)
Find it and CL did not provide any possible suspect.
Using Code Search for the file, "HTMLCanvasElement.cpp" assigning to the concern owner.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/5e87e713d6ed8c36fb37b814c6b65e7096d4554e

@xlai -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by xlai@chromium.org, Dec 21 2016

Owner: junov@chromium.org
junov@: I think this crash might be related to your recent change in https://chromium.googlesource.com/chromium/src/+/edbaf210e408c0c06c5f1dba250d1a5e33bb3c6e because that commit falls within the regression range. Also, I notice that HTMLCanvasElement::getSourceImageForCanvas calls createTransparentImage, which in your CL you've made it possible to return nullptr; I think that's the reason why getSourceImageForCanvas sometimes crashes.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaee8c63e6a1716c78b5e5715e1f96b8df4ed1e3

commit aaee8c63e6a1716c78b5e5715e1f96b8df4ed1e3
Author: junov <junov@chromium.org>
Date: Wed Dec 21 21:59:14 2016

Re-arrange some null pointer checks in HTMLCanvasElement.cpp

BUG= 675099 

Review-Url: https://codereview.chromium.org/2594093002
Cr-Commit-Position: refs/heads/master@{#440231}

[modify] https://crrev.com/aaee8c63e6a1716c78b5e5715e1f96b8df4ed1e3/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Project Member

Comment 4 by ClusterFuzz, Dec 22 2016

ClusterFuzz has detected this issue as fixed in range 440205:440307.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4974507636031488

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00000000
Crash State:
  blink::HTMLCanvasElement::getSourceImageForCanvas
  blink::HTMLCanvasElement::getSourceImageForCanvas
  blink::BaseRenderingContext2D::drawImage
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=434678:434769
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=440205:440307

Minimized Testcase (23.27 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96YEFtT4fwoE5_ffenGe4Eb-9RJYkoKHSE0XMLDLyJ3DgKBMeWX2QG16T7FKFTm8yGwmlQA3-O3TD8dvQK9vHMn8AW6-g_-dlZZ3jDDzGSBJoP7B31sElOJtTMhe0lmF3vUhFy_AxZxeCywyQEbXF1BhIfKcFfVIUd97EbKUYTGTwHZ6-s?testcase_id=4974507636031488

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Dec 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4974507636031488 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment