MD History: Unable to select text on unfocused items
Reported by
teo8...@gmail.com,
Dec 16 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: Test 1: 1. Go to history 2. click on the time on the left next to any of the results, or on the domain name on the right Test 2: 1. Go to history 2. try to select the text that displays the time on the left next to any of the results (or the domain name on the right) What is the expected behavior? Test 1: Either NOTHING, or it could check the checkbox on the left corresponding to the line you clicked Test 2: you should be able to select text (for example to copy it and paste it) What went wrong? Test 1: A grey circle appears highlighting the checkbox, as it would do if you had clicked on the checkbox (only in that case the checkbox would be checked and the highlighting circle would disappear), and the highlight remains forever, without checking the checkbox, leaving it in a nonsense status, not selected but highlighted for no reason. If you had previously clicked on any of the "..." dropdown menus on the right (there's one at every line), the "..." in the line in which you clicked will be highlighted in the above described nonsense fashion, instead of the checkbox Test 2: you are unable to select text. The same nonsense happens as in test 1. Did this work before? Yes before the retarded redesign of the history UI Chrome version: 55.0.2883.87 Channel: stable OS Version: Flash Version: Shockwave Flash 24.0 r0
,
Dec 19 2016
Thanks for taking the time to file an issue. Test 1: This was improved in issue 651556 , but fully fixed in issue 620036 . This fix was made as part of M56, which is estimated to release at the end of January. Test 2: This is an unfixed bug. I'll shuffle around the labels to suit. For future me, steps to reproduce: 1. Open MD History 2. Try to click-and-drag to select an item. Notice that the checkbox selects instead 3. Try again to click-and-drag on that item. It selects the second time. Expected behavior: The text should select on the first attempt.
,
Jun 24 2017
Issue 2 still unfixed after months. Also, when the item *is* focused, and you click and drag to select text, the text is selected as expected, but the checkbox is also unchecked while it shouldn't (it should only toggle its state on click, not on press-drag-release). Issue 1 is only partially fixed, the behavior is broken, see Issue 736597 . It's sad to see such basic mouse event handling errors in 2017.
,
Jun 29 2017
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/896d42e807efa7b168487deb1e2b530de715cdaa commit 896d42e807efa7b168487deb1e2b530de715cdaa Author: tsergeant <tsergeant@chromium.org> Date: Fri Jun 30 04:49:17 2017 MD History: Fix text selection in history items Clicking on a history item would immediately change focus if the item wasn't selected, preventing selection with the mouse. This fixes the issue by preventing the extra unnecessary change of focus. BUG= 675058 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2962103002 Cr-Commit-Position: refs/heads/master@{#483632} [modify] https://crrev.com/896d42e807efa7b168487deb1e2b530de715cdaa/chrome/browser/resources/md_history/history_item.js
,
Jul 3 2017
This issue should now be fixed in Chrome canary. Please feel free to comment if you're still seeing the issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted