Sheriffbot applying erroneous labels related to merges without tests |
||
Issue descriptionExamples: https://bugs.chromium.org/p/chromium/issues/detail?id=672019#c24 https://bugs.chromium.org/p/chromium/issues/detail?id=673571#c8 https://bugs.chromium.org/p/chromium/issues/list?can=1&q=Owners%3A+amineer%40%28clank%29%2C+cmasso%40%28bling%29%2C+gkihumba%40%28cros%29%2C+bustamante%40%28desktop%29&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids shows 74 affected issues. We need to stop applying these erroneous labels, and clean up items that were tagged inappropriately. Also, was this new rule reviewed and approved anywhere? I don't recall seeing any messaging about this and we should not be implementing it right now without sending details to chromium-dev@.
,
Dec 16 2016
We need to: - Ensure the AppScript version is running while we wait to reland and reenable this rule in SheriffBot - Remove any erroneously applied tags (not everything in my search result appears to be an error, but each of the examples above do appear to be errors from what I can tell, and I think there are more) - Review and approve the rule via Chrome PMO re: test files blocking an automated merge before re-adding that functionality - Communicate with chromium-dev@ before re-adding that functionality.
,
Dec 16 2016
It looks erroneous labels are adding to bugs that doesn't have 'Merge-Request-56', I'm investigating what has happened (FYI the sheriffbot CL was https://team-review.git.corp.google.com/#/c/57037/ the CL was intended to replace AppScript merge approval logic, the only new rule added was checking test files). - Ensure the AppScript version is running while we wait to reland and reenable this rule in SheriffBot AppScript is still running. - Remove any erroneously applied tags (not everything in my search result appears to be an error, but each of the examples above do appear to be errors from what I can tell, and I think there are more) I'm working on an AppScript that removing the erroneously label. - Review and approve the rule via Chrome PMO re: test files blocking an automated merge before re-adding that functionality - Communicate with chromium-dev@ before re-adding that functionality. The test files functionality was tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=652875. I will communicate with chrome-pmo@ and chromium-dev@ before adding the functionality.
,
Dec 16 2016
We found the issue is that the query should be "label:Merge-Request-MXX" instead of "Merge-Request-MXX", which only does a string search.
,
Dec 17 2016
All incorrect label has been cleaned up. The two left in the list are correctly labelled: https://bugs.chromium.org/p/chromium/issues/list?can=1&q=label%3AMerge-review-56+Owners%3A+amineer%40%28clank%29%2C+cmasso%40%28bling%29%2C+gkihumba%40%28cros%29%2C+bustamante%40%28desktop%29&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids |
||
►
Sign in to add a comment |
||
Comment 1 by mbarbe...@chromium.org
, Dec 16 2016