New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675056 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

History search result don't show the time, only date

Reported by teo8...@gmail.com, Dec 16 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. go to History/History
2. Enter some string in the search box on the top
3. Look at the results

What is the expected behavior?
You should be able to see the date AND TIME at which each result was visited.

What went wrong?
The first column shows only the date of each entry, but not the time. Not even by clicking on rolling over the date does it show the full date and time. It's completely retarded.

Did this work before? Yes don't know, before the "brilliant" redesign of the history UI. 

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 24.0 r0

When you browse your history without searching, there's a header with the date separating each day, and the first column shows the time, so you know the date and time, as expected.
 
Labels: M-55
Cc: dpa...@chromium.org
Components: -UI UI>Settings
Labels: -M-55 -Type-Bug-Regression Proj-MaterialDesign-WebUI M-57 Type-Feature
Status: Untriaged (was: Unconfirmed)
Considering the above issue as Feature and marking it as untriaged.

Thanks!

Comment 3 by teo8...@gmail.com, Dec 20 2016

A feature?? You must be kidding me
Components: -UI>Settings UI>Browser>History
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
Rolling over the date does indeed show the time. However it seems like we could make it top-level. @bettes any thoughts? Could we show the date instead of a divider line, then the time with each item as in the normal view?

Comment 5 by teo8...@gmail.com, Feb 7 2017

> Rolling over the date does indeed show the time.

Funny, that definitely wasn't happening when I reported the issue.

Comment 6 by bettes@chromium.org, Feb 22 2017

Labels: -Pri-2 Pri-3
Owner: ----
Status: Untriaged (was: Assigned)
> Rolling over the date does indeed show the time.

That's not the case for me either. 

> Considering the above issue as Feature and marking it as untriaged.

Not showing the time in search results is parity with what we do today and reaching feature parity is our main objective at the moment. Marking this as P3 for now. Thanks for the feedback! 



search.png
169 KB View Download
Owner: tsergeant@chromium.org
Status: Started (was: Untriaged)
As discussed above, the full timestamp does show up in a tooltip when hovering over the date/time.

There's a little bug I've just found with that where the timestamp won't update correctly. Taking ownership to fix that issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47c2896ff9bad0082bf8abddd0e55bfdd843a959

commit 47c2896ff9bad0082bf8abddd0e55bfdd843a959
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jun 30 04:45:33 2017

MD History: Update timestamp hover text when item changes

This fixes an issue where the time title would be stuck on the first
value it was set to, never updating as the list was scrolled and
changed.

The end result is that the code matches patchset 2 of
https://codereview.chromium.org/2454303002/.

BUG= 675056 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2962133002
Cr-Commit-Position: refs/heads/master@{#483630}

[modify] https://crrev.com/47c2896ff9bad0082bf8abddd0e55bfdd843a959/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/47c2896ff9bad0082bf8abddd0e55bfdd843a959/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/47c2896ff9bad0082bf8abddd0e55bfdd843a959/chrome/test/data/webui/md_history/history_item_test.js

Status: Fixed (was: Started)
Canary should now have the hover text present and correct.

Sign in to add a comment