New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Project Member Reported by rjkroege@chromium.org, Dec 16 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Type: build-failure

Builders failed on: 
- WebKit Linux Trusty (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29


The test:
virtual/android/fullscreen/full-screen-stacking-context.html

is not rendering correctly.

Series of changes to style resolution between chromium: 439096 - 439124 would seem to be the most likely.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2776787d4f148793c214c010ee3892ed1a6646e5

commit 2776787d4f148793c214c010ee3892ed1a6646e5
Author: rjkroege <rjkroege@chromium.org>
Date: Fri Dec 16 21:25:57 2016

TestExpectation: virtual/android/fullscreen/full-screen-stacking-context.html fail

virtual/android/fullscreen/full-screen-stacking-context.html is
failing on Linux Trusty. Marked as such.

TBR=rune@opera.com
NOTRY=true
BUG= 675055 

Review-Url: https://codereview.chromium.org/2578093004
Cr-Commit-Position: refs/heads/master@{#439191}

[modify] https://crrev.com/2776787d4f148793c214c010ee3892ed1a6646e5/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by r...@opera.com, Dec 19 2016

Able to reproduce locally running layout tests with Linux debug content_shell.

Comment 3 by r...@opera.com, Dec 19 2016

Status: Started (was: Assigned)
Labels: -Sheriff-Chromium

Comment 5 by r...@opera.com, Dec 19 2016

This was flaky even before my changes. I have a build based on crrev.com/7d9ae119 which also fails running with --repeat-each=30. Going fullscreen, the media controls are first painted without the slider, and then the slider layout object is created, layed out, and painted. This test fails when we pixel dump the first paint instead of the second.

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2592279f64b3a80329edef372adf6283349a0b

commit 9d2592279f64b3a80329edef372adf6283349a0b
Author: rune <rune@opera.com>
Date: Mon Dec 19 16:01:04 2016

Fixed flaky fullscreen video test.

The media controls are (at least sometimes) painted twice. The second
time after figuring out how many buttons fit into the available width.
At least one of the fullscreen tests were flaky because the first paint
was dumped instead of the second one. Adding a layoutAndPaintAsyncThen
in the full-screen-test.js framework seems to fix the issue.

Although the issue was filed after landing changes for  issue 567021 ,
the flakiness is also seen locally without those changes running the
test with --repeat-each=30 in debug.

R=fs@opera.com
TEST=virtual/android/fullscreen/full-screen-stacking-context.html
BUG= 675055 

Review-Url: https://codereview.chromium.org/2586243002
Cr-Commit-Position: refs/heads/master@{#439483}

[modify] https://crrev.com/9d2592279f64b3a80329edef372adf6283349a0b/third_party/WebKit/LayoutTests/fullscreen/full-screen-test.js

rune@ should you remove the test expectation change? Or is the test still too flaky?
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1e7221a2eb2b40d90d4fb73a82455448331b98

commit 5c1e7221a2eb2b40d90d4fb73a82455448331b98
Author: rune <rune@opera.com>
Date: Tue Dec 20 06:06:46 2016

Removed expected Trusty dbg failure after fix.

R=rjkroege@chromium.org
BUG= 675055 

Review-Url: https://codereview.chromium.org/2586393002
Cr-Commit-Position: refs/heads/master@{#439723}

[modify] https://crrev.com/5c1e7221a2eb2b40d90d4fb73a82455448331b98/third_party/WebKit/LayoutTests/TestExpectations

Comment 11 by r...@opera.com, Dec 20 2016

Status: Fixed (was: Started)

Sign in to add a comment