New issue
Advanced search Search tips

Issue 675046 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Deduplicate content/chrome media browser tests

Project Member Reported by xhw...@chromium.org, Dec 16 2016

Issue description

We have many duplicate code between content and chrome MediaBrowserTest. The same for EncryptedMediaTest. 

Today they share the same set of js/html, but the C++ handling is duplicated. The C++ code diverges over time, sometimes introducing bugs.

For example, in chrome, kError is "error", with an explanation and TODO to optimize it [1]. But in content, kError is "ERROR" [2], which is a bug.

I think some common helper/util file/class would make some sense so that the two tests can share the same mechanism how to interact with js/html.

[1] https://cs.chromium.org/chromium/src/chrome/browser/media/media_browsertest.cc?rcl=0&l=28

[2] https://cs.chromium.org/chromium/src/content/browser/media/media_browsertest.cc?rcl=0&l=24

 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
stale bug for > 1 year.

Sign in to add a comment