New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Return a URL for nav timing 2's name field

Project Member Reported by sunjian@chromium.org, Dec 16 2016

Issue description

Right now, the name field in nav timing 2 instance is always "document". Returning a URL might be more appropriate.
 
We should bring this up on the spec + working group first. 
Ilya, is there a spec bug for this or should we file one?
This seems like a general question for PerformanceEntry and not specific to NT2.
(I recall previous discussion but can't find the issue)

Cc: sunjian@chromium.org
Owner: ----
We should open a bug on NT2. 

FWIW, RT2 provides the resolved URL in name: http://w3c.github.io/resource-timing/#performanceresourcetiming. In NT2 we override that and report "document". 

Given that in NT2 we only ever report one navtiming entry, perhaps this is not a big deal and something we can live with. However, thinking a little bit ahead... We *do* want to expose other navigation requests (e.g. redirects) as separate entries, and when we do so, we need to expose the URL (which means name field should report URLs). Perhaps its not too late for us to make the change and make developer lives easier down the road..
Owner: panicker@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af62af4bf7a7b092fd5d81acc56e316a01244db

commit 0af62af4bf7a7b092fd5d81acc56e316a01244db
Author: panicker <panicker@chromium.org>
Date: Tue Feb 07 02:27:39 2017

Update NT2 name to be the requested URL instead of 'document'
There's a strong request to merge this in M57, see spec bug: https://github.com/w3c/navigation-timing/issues/59

BUG= 675039 

Review-Url: https://codereview.chromium.org/2675973004
Cr-Commit-Position: refs/heads/master@{#448517}

[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/LayoutTests/external/wpt/navigation-timing/nav2_test_attributes_values.html
[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/LayoutTests/external/wpt/navigation-timing/nav2_test_instance_accessors.html
[delete] https://crrev.com/7eea8952954c9b0db9ac932efc2389ba793c6e55/third_party/WebKit/LayoutTests/http/tests/performance-timing/test-navigation-timing2-attributes-exist.html
[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_values.html
[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html
[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
[modify] https://crrev.com/0af62af4bf7a7b092fd5d81acc56e316a01244db/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h

Labels: Merge-Request-57
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 8 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a9168ce53f0b1b592ba8305116fc235d704970

commit 33a9168ce53f0b1b592ba8305116fc235d704970
Author: Shubhie Panicker <panicker@chromium.org>
Date: Wed Feb 08 23:53:16 2017

Update NT2 name to be the requested URL instead of 'document' There's a strong request to merge this in M57, see spec bug: https://github.com/w3c/navigation-timing/issues/59

BUG= 675039 

Review-Url: https://codereview.chromium.org/2675973004
Cr-Commit-Position: refs/heads/master@{#448517}
(cherry picked from commit 0af62af4bf7a7b092fd5d81acc56e316a01244db)

Review-Url: https://codereview.chromium.org/2686973002 .
Cr-Commit-Position: refs/branch-heads/2987@{#397}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[delete] https://crrev.com/881c9bb76ee7f1ecd1b77e9dc45852535c8f3fa2/third_party/WebKit/LayoutTests/http/tests/performance-timing/test-navigation-timing2-attributes-exist.html
[modify] https://crrev.com/33a9168ce53f0b1b592ba8305116fc235d704970/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_values.html
[modify] https://crrev.com/33a9168ce53f0b1b592ba8305116fc235d704970/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html
[modify] https://crrev.com/33a9168ce53f0b1b592ba8305116fc235d704970/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/33a9168ce53f0b1b592ba8305116fc235d704970/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
[modify] https://crrev.com/33a9168ce53f0b1b592ba8305116fc235d704970/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h

Status: Fixed (was: Assigned)

Sign in to add a comment