New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675036 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Types with persistence error are not unapplied on reconfiguration

Project Member Reported by pav...@chromium.org, Dec 16 2016

Issue description

Types with persistence error should be unapplied. Their server data should be applied to local state during next sync cycle.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/483a408c43aa945fcafef315fb55ed6d3a00c663

commit 483a408c43aa945fcafef315fb55ed6d3a00c663
Author: pavely <pavely@chromium.org>
Date: Sat Dec 17 02:37:04 2016

[Sync] Ensure that CONFIGURE_CLEAN types get unapplied before configuration

The issue is that in SyncBackendHostImpl::ConfigureDataTypes types in
clean_first_types are excluded from types_to_purge and therefore are not being
unapplied as part of  PurgeDisabledTypes call.

This affects purgiong types with persistence error as well as catchup phase of
enabling passphrase encryption.

I'm adjusted logic to include these types in unapply_types and added test for
this scenario.

BUG= 675036 
R=zea@chromium.org

Review-Url: https://codereview.chromium.org/2580033002
Cr-Commit-Position: refs/heads/master@{#439297}

[modify] https://crrev.com/483a408c43aa945fcafef315fb55ed6d3a00c663/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/483a408c43aa945fcafef315fb55ed6d3a00c663/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/483a408c43aa945fcafef315fb55ed6d3a00c663/components/sync/engine/fake_sync_manager.cc
[modify] https://crrev.com/483a408c43aa945fcafef315fb55ed6d3a00c663/components/sync/engine/fake_sync_manager.h
[modify] https://crrev.com/483a408c43aa945fcafef315fb55ed6d3a00c663/components/sync/test/engine/test_syncable_utils.cc

Comment 2 by pav...@chromium.org, Jan 17 2018

Status: Fixed (was: Started)

Sign in to add a comment