New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675019 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: ----



Sign in to add a comment

browser_tests failing on chromium.memory/Mac ASan 64 Tests (1)

Project Member Reported by rjkroege@chromium.org, Dec 16 2016

Issue description

browser_tests failing on chromium.memory/Mac ASan 64 Tests (1)

Type: build-failure

Builders failed on: 
- Mac ASan 64 Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29


Details:

BrowserNavigatorTest.Disposition_IncognitoRefocus (run #1):
[ RUN      ] BrowserNavigatorTest.Disposition_IncognitoRefocus
[39572:51459:1216/095951.998532:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.uv1smE/dgIBnpv/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[39572:51459:1216/095952.251965:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.uv1smE/dgIBnpv/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[39578:3335:1216/095952.344538:WARNING:vt_video_decode_accelerator_mac.cc(169)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[39578:3335:1216/095952.346333:WARNING:vt_video_decode_accelerator_mac.cc(191)] Failed to create hardware VideoToolbox session
[39578:3335:1216/095952.420460:ERROR:vt_video_encode_accelerator_mac.cc(518)]  VTCompressionSessionCreate failed: -12908
[39572:2823:1216/095953.555507:ERROR:mach_port_broker.mm(175)] Unknown process 39585 is sending Mach IPC messages!
[39572:37891:1216/095953.610389:ERROR:service_manager_context.cc(143)] Attempting to run unsupported native service: /b/swarm_slave/w/ir_dXCSn/out/Release/./content_browser/content_browser.service
[39572:37891:1216/095953.611175:FATAL:interface_endpoint_client.cc(32)] Check failed: !is_valid. The callback passed to Connector::Connect() was never run.
0   browser_tests                       0x00000001085b0e83 _ZN4base5debug10StackTraceC1Ev + 19
1   browser_tests                       0x00000001086107c0 _ZN7logging10LogMessageD2Ev + 336
2   browser_tests                       0x000000010c86f2db _ZN4mojo12_GLOBAL__N_115DCheckIfInvalidERKN4base7WeakPtrINS_23InterfaceEndpointClientEEERKNSt3__112basic_stringIcNS7_11char_traitsIcEENS7_9allocatorIcEEEE + 715
3   browser_tests                       0x000000010c86ead5 _ZN4mojo12_GLOBAL__N_114ResponderThunk13DCheckInvalidERKNSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEE + 437
4   browser_tests                       0x0000000103ef44fb _ZN4base8internal9BindStateIMN15service_manager5mojom34Connector_Connect_ProxyToResponderEFvNS3_13ConnectResultERKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEEEJNS0_13PassedWrapperINS6_10unique_ptrIS4_NS6_14default_deleteIS4_EEEEEEEED2Ev + 491
5   browser_tests                       0x0000000103ef42f6 _ZN4base8internal9BindStateIMN15service_manager5mojom34Connector_Connect_ProxyToResponderEFvNS3_13ConnectResultERKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEEEJNS0_13PassedWrapperINS6_10unique_ptrIS4_NS6_14default_deleteIS4_EEEEEEEE7DestroyEPKNS0_13BindStateBaseE + 22
6   browser_tests                       0x0000000104254273 _ZN15service_manager13ConnectParamsD1Ev + 35
7   browser_tests                       0x000000010427703b _ZN4base8internal13FunctorTraitsIMN15service_manager14ServiceManagerEFvNSt3__110unique_ptrINS2_13ConnectParamsENS4_14default_deleteIS6_EEEEN4mojo12InterfacePtrINS2_5mojom7ServiceEEEbNS_7WeakPtrINS3_8InstanceEEENSA_9StructPtrINSC_13ResolveResultEEEEvE6InvokeIRKNSF_IS3_EEJS9_SE_RKbRKSH_SK_EEEvSM_OT_DpOT0_ + 1307
8   browser_tests                       0x0000000104276937 _ZN4base8internal7InvokerINS0_9BindStateIMN15service_manager14ServiceManagerEFvNSt3__110unique_ptrINS3_13ConnectParamsENS5_14default_deleteIS7_EEEEN4mojo12InterfacePtrINS3_5mojom7ServiceEEEbNS_7WeakPtrINS4_8InstanceEEENSB_9StructPtrINSD_13ResolveResultEEEEJNSG_IS4_EENS0_13PassedWrapperISA_EENSP_ISF_EEbSI_EEEFvSL_EE7RunImplIRKSN_RKNS5_5tupleIJSO_SQ_SR_bSI_EEEJLm0ELm1ELm2ELm3ELm4EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOSL_ + 1079
9   browser_tests                       0x0000000103ef9895 _ZN15service_manager5mojom42Resolver_ResolveMojoName_ForwardToCallback6AcceptEPN4mojo7MessageE + 757
10  browser_tests                       0x000000010c869cd5 _ZN4mojo23InterfaceEndpointClient22HandleValidatedMessageEPNS_7MessageE + 2773
11  browser_tests                       0x000000010c868661 _ZN4mojo11FilterChain6AcceptEPNS_7MessageE + 513
12  browser_tests                       0x000000010c86cf49 _ZN4mojo23InterfaceEndpointClient21HandleIncomingMessageEPNS_7MessageE + 281
13  browser_tests                       0x000000010c87fa81 _ZN4mojo8internal15MultiplexRouter22ProcessIncomingMessageEPNS_7MessageENS1_18ClientCallBehaviorEPN4base22SingleThreadTaskRunnerE + 2513
14  browser_tests                       0x000000010c87e651 _ZN4mojo8internal15MultiplexRouter6AcceptEPNS_7MessageE + 609
15  browser_tests                       0x000000010c868661 _ZN4mojo11FilterChain6AcceptEPNS_7MessageE + 513
16  browser_tests                       0x000000010c85d78c _ZN4mojo9Connector17ReadSingleMessageEPj + 604
17  browser_tests                       0x000000010c85e364 _ZN4mojo9Connector21OnHandleReadyInternalEj + 452
18  browser_tests                       0x000000010c89d373 _ZN4mojo7Watcher13OnHandleReadyEj + 595
19  browser_tests                       0x000000010c89cdeb _ZN4mojo7Watcher17CallOnHandleReadyEmj22MojoHandleSignalsStatej + 523
20  browser_tests                       0x000000010e7e44ad _ZN4mojo3edk7Watcher19MaybeInvokeCallbackEjRKNS0_18HandleSignalsStateEj + 525
21  browser_tests                       0x000000010e7d06cb _ZN4mojo3edk14RequestContextD2Ev + 1275
22  browser_tests                       0x000000010e7d06d3 _ZN4mojo3edk14RequestContextD2Ev + 1283
23  browser_tests                       0x000000010e7d06d3 _ZN4mojo3edk14RequestContextD2Ev + 1283
24  browser_tests                       0x000000010e799e2f _ZN4mojo3edk11NodeChannel16OnChannelMessageEPKvmNSt3__110unique_ptrINS4_6vectorINS0_14PlatformHandleENS4_9allocatorIS7_EEEENS0_27PlatformHandleVectorDeleterEEE + 10383
25  browser_tests                       0x000000010e75678f _ZN4mojo3edk7Channel14OnReadCompleteEmPm + 1919
26  browser_tests                       0x000000010e75ae43 _ZN4mojo3edk12_GLOBAL__N_112ChannelPosix28OnFileCanReadWithoutBlockingEi + 1411
27  browser_tests                       0x0000000108656f65 _ZN4base19MessagePumpLibevent22OnLibeventNotificationEisPv + 1189
28  browser_tests                       0x000000010bfabc2d event_base_loop + 3965
29  browser_tests                       0x00000001086575f9 _ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE + 569
30  browser_tests                       0x000000010864c101 _ZN4base11MessageLoop10RunHandlerEv + 817
31  browser_tests                       0x00000001086d944a _ZN4base7RunLoop3RunEv + 362
32  browser_tests                       0x000000010877cce4 _ZN4base6Thread3RunEPNS_7RunLoopE + 468
33  browser_tests                       0x00000001067a73dd _ZN7content17BrowserThreadImpl11IOThreadRunEPN4base7RunLoopE + 237
34  browser_tests                       0x00000001067a77fc _ZN7content17BrowserThreadImpl3RunEPN4base7RunLoopE + 716
35  browser_tests                       0x000000010877d961 _ZN4base6Thread10ThreadMainEv + 1841
36  browser_tests                       0x0000000108768f3e _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 206
37  libsystem_pthread.dylib             0x00007fff906e6899 _pthread_body + 138
38  libsystem_pthread.dylib             0x00007fff906e672a _pthread_struct_init + 0
39  libsystem_pthread.dylib             0x00007fff906eafc9 thread_start + 13

 
Cc: roc...@chromium.org
rockot@: Can you suggest why this is happening beyond the obvious that someone is passing an invalid handle to Connector::Connect()


Comment 2 by roc...@chromium.org, Dec 16 2016

Cc: -roc...@chromium.org rjkroege@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Available)
That's not what's happening at all actually. This indicates a bug in ServiceManager. Specifically there must be some edge case where it complete a Connect request without either closing the Connector pipe or calling the response callback.
Thanks for taking this on.


Comment 4 by roc...@chromium.org, Dec 16 2016

Issue 674654 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05cb8ae729c29d4f69626ac0c59b49e2259c5f9f

commit 05cb8ae729c29d4f69626ac0c59b49e2259c5f9f
Author: rockot <rockot@chromium.org>
Date: Fri Dec 16 23:13:52 2016

Respond to Connector::Connect when a native service binary fails to launch

Otherwise we hit a DCHECK in the bindings, because the Connector
pipe is still open when we drop the callback.

BUG= 675019 

Review-Url: https://codereview.chromium.org/2581873003
Cr-Commit-Position: refs/heads/master@{#439227}

[modify] https://crrev.com/05cb8ae729c29d4f69626ac0c59b49e2259c5f9f/services/service_manager/service_manager.cc

Comment 6 by roc...@chromium.org, Dec 16 2016

Status: Fixed (was: Assigned)

Sign in to add a comment