Issue metadata
Sign in to add a comment
|
It2Me Connection may fail for users who get mixed-case JIDs. |
||||||||||||||||||||
Issue descriptionIf helpee gets mixed-case JID from the XMPP server (e.g. JohnDoe@gmail.com/foo) then the client always fails to connect. The problem is that the JID is stored in normalized form in the directory, while messages from host contains mixed-case from attribute. JID comparison fails here: https://codesearch.chromium.org/chromium/src/remoting/protocol/jingle_session.cc?rcl=1481890797&l=500 I believe we had this scenario working in the past
,
Dec 16 2016
Pending fix: https://codereview.chromium.org/2577333003/
,
Dec 18 2016
Is this something we can get merged into M56 one it lands? The fix seems straightforward and would fix a confusing error scenario w/o a workaround (besides using a different account).
,
Dec 19 2016
Will merge to M56
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/428e8936ff8346722f3268db7b7d8df7117f5ad9 commit 428e8936ff8346722f3268db7b7d8df7117f5ad9 Author: sergeyu <sergeyu@chromium.org> Date: Mon Dec 19 23:53:19 2016 Update SignalingAddress to normalize all JIDs. Previously JIDs were not normalized consistently which results in failure to connect when host has mixed-case JID. This CL fixes it by making SignalingAddress always normalize all JIDs. Also it's now a class instead of struct, to ensure that the content is always consistent. BUG= 675014 Review-Url: https://codereview.chromium.org/2577333003 Cr-Commit-Position: refs/heads/master@{#439623} [modify] https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9/remoting/protocol/jingle_messages.cc [modify] https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9/remoting/protocol/jingle_messages.h [modify] https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9/remoting/protocol/jingle_messages_unittest.cc [modify] https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9/remoting/protocol/jingle_session_unittest.cc [modify] https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9/remoting/signaling/fake_signal_strategy.cc
,
Dec 20 2016
The change doesn't affect chrome, only chromoting.
,
Dec 20 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce9009479f12fa5b335f53a027a6ec8ebef69af6 commit ce9009479f12fa5b335f53a027a6ec8ebef69af6 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Dec 21 00:11:58 2016 Update SignalingAddress to normalize all JIDs. Previously JIDs were not normalized consistently which results in failure to connect when host has mixed-case JID. This CL fixes it by making SignalingAddress always normalize all JIDs. Also it's now a class instead of struct, to ensure that the content is always consistent. BUG= 675014 Review-Url: https://codereview.chromium.org/2577333003 Cr-Commit-Position: refs/heads/master@{#439623} (cherry picked from commit 428e8936ff8346722f3268db7b7d8df7117f5ad9) Review-Url: https://codereview.chromium.org/2591953002 . Cr-Commit-Position: refs/branch-heads/2924@{#571} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/ce9009479f12fa5b335f53a027a6ec8ebef69af6/remoting/protocol/jingle_messages.cc [modify] https://crrev.com/ce9009479f12fa5b335f53a027a6ec8ebef69af6/remoting/protocol/jingle_messages.h [modify] https://crrev.com/ce9009479f12fa5b335f53a027a6ec8ebef69af6/remoting/protocol/jingle_messages_unittest.cc [modify] https://crrev.com/ce9009479f12fa5b335f53a027a6ec8ebef69af6/remoting/protocol/jingle_session_unittest.cc [modify] https://crrev.com/ce9009479f12fa5b335f53a027a6ec8ebef69af6/remoting/signaling/fake_signal_strategy.cc
,
Dec 21 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sergeyu@chromium.org
, Dec 16 2016Labels: -Type-Bug Type-Bug-Regression