New issue
Advanced search Search tips

Issue 675008 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Payment Request] When adding a billing address, canceling clears the selection

Project Member Reported by ma...@chromium.org, Dec 16 2016 
Title says it all, adding a billing address on a card and cancelling the editor will reset the selection, which is not the correct thing to do in all cases (say there was a billing address selected previously).
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95937f0e845bff960f00df8d546df266709d9f15

commit 95937f0e845bff960f00df8d546df266709d9f15
Author: mathp <mathp@chromium.org>
Date: Fri Dec 16 22:22:00 2016

[PR] Fix selection when cancelling out of add billing address flow

Previously, cancelling out of ADD ADDRESS flow in card editor would
always clear the billing address dropdown selection. We now restore it
properly.

BUG= 675008 
TEST=PaymentRequestBillingAddress*

Review-Url: https://codereview.chromium.org/2581293002
Cr-Commit-Position: refs/heads/master@{#439217}

[modify] https://crrev.com/95937f0e845bff960f00df8d546df266709d9f15/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/95937f0e845bff960f00df8d546df266709d9f15/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java
[modify] https://crrev.com/95937f0e845bff960f00df8d546df266709d9f15/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 2 by ma...@chromium.org, Dec 17 2016

Status: Fixed (was: Started)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment