Log is at https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/675006/

Issue 674675 has been merged into this issue.

https://code.google.com/p/chrome-os-partner/issues/detail?id=60718 changed kernel from 3.10 to 4.4. I don't know why we want to do that. Apparently there are some missing CLs for external mic to work.

Kernel 4.4 uses input event named
"byt-max98090 Headset"

Kernel 3.10 uses input event
"byt-max98090 Headphone Jack"
"byt-max98090 Mic Jack"

We should use mandatory UCM on squawks to avoid this naming issue.
We should also move ucm config and cras config to overlay.

With this change https://chromium-review.googlesource.com/422793 switching squawks to use mandatory UCM, I can pass headphone and external mic test.
I plan to move config to overlay after we have a stable config.

However, there are still more issues to solve. For example, https://code.google.com/p/chrome-os-partner/issues/detail?id=61272

I just found this one, and there might be others.

For example: these are two minor issues that we have fixed in 3.10

https://code.google.com/p/chrome-os-partner/issues/detail?id=26094
https://bugs.chromium.org/p/chromium/issues/detail?id=415156

3.10 and 4.4 have diverged a lot.
We need to check all the fixes again and port them to 4.4 one by one.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/db456bf83d05f655ae3d299a433bb562f6f15c0e

commit db456bf83d05f655ae3d299a433bb562f6f15c0e
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Dec 22 09:15:52 2016

ucm-config: squawks: Switch to mandatory UCM

- Use mandatory UCM to specify jack for kernel 4.4.
- Remove redundant 'Left Speaker Mixer Left DAC Switch' and
  'Right Speaker Mixer Right DAC Switch' in initial sequence.
- Remove 'HP Left Out Switch' and 'HP Right out Switch'
  because kernel 4.4 does not export such control. This can be
  added back when kernel support is ready.

BUG= chromium:675006 
TEST=check headphone / external mic works on squawks.
TEST=check internal speaker / internal mic works on squawks.
     Note sometimes recording fail because of PLL unlocked issue.

Change-Id: Id680d058bff6e1038e109d0ba32cf31e6e9d893b
Reviewed-on: https://chromium-review.googlesource.com/422793
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/db456bf83d05f655ae3d299a433bb562f6f15c0e/ucm-config/squawks/byt-max98090/HiFi.conf

Can you please request merge to M57 if this is already validated?

cychiang@ can you please comment on #10?

I guess this has dependency on when CL:431315 merge to M-57.

Approving merge to M57 Chrome OS.

Here is the response about 4.4 migration plan from https://bugs.chromium.org/p/chromium/issues/detail?id=681891#c16

M57: Only clapper, Quawks, Squawks have 4.4. The remaining ones will continue to have 3.10

M58: All the others are also migrated to 4.4. This was done so as to wait for some user feedback before we enable on all.

So for a CL, if it really depends on 4.4, we can cherrypick it partially so that only Clapper, Squawks, Quawks make it in M57.

Thanks,

Rajat

I see.
In this issue I only migrate the audio config from 3.10 to 4.4 for squawks, on ToT.
Hsinyu did migration work for other rambi boards in  issue 681891 , along with moving the configs from adhd repo to overlay.
The cherry-pick work should be done in  issue 681891 .
On R57, move configs of clapper, quawks, squawks from adhd to overlay, and modify them for 4.4.
So I will remove the merge approval on this issue, and set the blocked-on for 681891.

cychiang@ Do we need more time to add the CLs to M57?

Related CLs are merged per  issue 681891 .

[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.

Thanks hychao for the fix.

Hi Sridhar, could you please verify on R57 squawks ?

Thanks!

It looks like the four autotests passed at R57-9151.0.0	on Thu Jan 05, 00:53
https://screenshot.googleplex.com/oTCRkCU33UR

confirmed from the change
db456bf8	422793	675006	Thu Dec 22 09:15:52 2016	cychiang@chromium.org	ucm-config: squawks: Switch to mandatory UCM
shown in the diff https://crosland.corp.google.com/log/9150.0.0..9151.0.0