pageLoaded: should be fully replaced by CRWWebStateObserver::PageLoaded. setWebViewProxy:controller: should be fully replaced by WebState::GetWebViewProxy
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4736030020471fa4dca4eb223925cfdac92267df commit 4736030020471fa4dca4eb223925cfdac92267df Author: eugenebut <eugenebut@chromium.org> Date: Sat Mar 04 02:33:58 2017 Removed CRWWebController dependency from NativeAppNavigationController. Conform NativeAppNavigationController to CRWWebStateObserver instead of CRWWebControllerObserver. BUG= 675005 , 619984 Review-Url: https://codereview.chromium.org/2731443003 Cr-Commit-Position: refs/heads/master@{#454751} [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/BUILD.gn [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/DEPS [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/tabs/tab.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7efabb4a472a7fdd10f7d4a3d0ec6b7915b238b5 commit 7efabb4a472a7fdd10f7d4a3d0ec6b7915b238b5 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 08 13:33:38 2017 Remove CRWWebControllerObserver [1/N]. Add another initializer to OverscrollActionsController taking a CRWWebViewProxy instead of depending on invocation of the -setWebViewProxy:controller: method to get the proxy. Remove the code listening to -webControllerWillClose: as the owner of OverscrollActionsController already call -invalidate to break the connection to the CRWWebViewProxy as part of the WebState shutdown. Bug: 675005 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iec5cb151df46781c6b5cba8bbdc4d560378bc951 Reviewed-on: https://chromium-review.googlesource.com/753363 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#514811} [modify] https://crrev.com/7efabb4a472a7fdd10f7d4a3d0ec6b7915b238b5/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/7efabb4a472a7fdd10f7d4a3d0ec6b7915b238b5/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h [modify] https://crrev.com/7efabb4a472a7fdd10f7d4a3d0ec6b7915b238b5/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/878336fdaee205471ad4beb8154253c19c5ce983 commit 878336fdaee205471ad4beb8154253c19c5ce983 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 09 11:03:37 2017 Remove CRWWebControllerObserver [2/N]. Convert LegacyFullscreenController to be a CRWWebStateObserver and listen for -webState:didLoadPageWithSuccess:. Pass the WebState to LegacyFullscreenController initializer so that it can fetch the id<CRWWebViewProxy> directly instead of waiting for -setWebViewProxy:controller: event. Add SetWebViewProxy() method to TestWebState so that the unit test of LegacyFullscreenController can inject the dependency. Bug: 675005 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id574672174d45577968d3912ad7467c1f73f94fe Reviewed-on: https://chromium-review.googlesource.com/758997 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515136} [modify] https://crrev.com/878336fdaee205471ad4beb8154253c19c5ce983/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/878336fdaee205471ad4beb8154253c19c5ce983/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller.h [modify] https://crrev.com/878336fdaee205471ad4beb8154253c19c5ce983/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller.mm [modify] https://crrev.com/878336fdaee205471ad4beb8154253c19c5ce983/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller_unittest.mm [modify] https://crrev.com/878336fdaee205471ad4beb8154253c19c5ce983/ios/web/public/test/fakes/test_web_state.h [modify] https://crrev.com/878336fdaee205471ad4beb8154253c19c5ce983/ios/web/public/test/fakes/test_web_state.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c344401baab3be225b0f7e70b6868c08e58fa90c commit c344401baab3be225b0f7e70b6868c08e58fa90c Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 10 20:33:04 2017 Remove CRWWebControllerObserver [3/3]. Clear the CRWWebController delegate in -close method, and remove the -webControllerWillClose: notification that was only used to call clear the delegate. Remove CRWebControllerObserver as there is no class implementing the protocol. Remove all helper and test classes. Fix all comments to not refer to CRWWebControllerObserver. Bug: 675005 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I01147539158a565cdae2ced35b0d20483b7a61eb Reviewed-on: https://chromium-review.googlesource.com/763233 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515662} [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/BUILD.gn [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/public/BUILD.gn [delete] https://crrev.com/be3421dd36e991fdd4e90417c9febd5b323982e5/ios/web/public/web_state/crw_web_controller_observer.h [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/test/BUILD.gn [delete] https://crrev.com/be3421dd36e991fdd4e90417c9febd5b323982e5/ios/web/test/crw_fake_web_controller_observer.h [delete] https://crrev.com/be3421dd36e991fdd4e90417c9febd5b323982e5/ios/web/test/crw_fake_web_controller_observer.mm [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/web_state/BUILD.gn [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/web_state/js/resources/form.js [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/web_state/ui/BUILD.gn [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/web_state/ui/crw_web_controller.mm [delete] https://crrev.com/be3421dd36e991fdd4e90417c9febd5b323982e5/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm [modify] https://crrev.com/c344401baab3be225b0f7e70b6868c08e58fa90c/ios/web/web_state/ui/crw_web_controller_unittest.mm [delete] https://crrev.com/be3421dd36e991fdd4e90417c9febd5b323982e5/ios/web/web_state/web_controller_observer_bridge.h [delete] https://crrev.com/be3421dd36e991fdd4e90417c9febd5b323982e5/ios/web/web_state/web_controller_observer_bridge.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a85d252634b98340186f9d90661f20da80a230fe commit a85d252634b98340186f9d90661f20da80a230fe Author: Sylvain Defresne <sdefresne@google.com> Date: Mon Nov 20 10:40:45 2017
Comment 1 by bugdroid1@chromium.org
, Mar 4 2017